Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Urdu Localization Team Approvers #1324

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Add Urdu Localization Team Approvers #1324

merged 2 commits into from
Sep 20, 2022

Conversation

seokho-son
Copy link
Collaborator

@seokho-son seokho-son commented Sep 19, 2022

Signed-off-by: Seokho Son shsongist@gmail.com

Based on

This PR add approvers for Urdu Localization

Important

  • All candidates need to leave a comment in this PR that you understood the following policies and information. (l10n teams: please share this message to candidates)
  • The l10n team approvers need to use your permission appropriately.
    • The approvers of l10n team will have a push permission to this repository.
      It is to make l10n approvers manage (merge) PRs for l10n contributions in your development branch.
      Merging a PR to the main branch by l10n approvers is restricted.
      Even if they are possible to review a PR to the main branch and give an approval to the PR, they should not approve the PR.
      So, please do not approve if a PR is not related with your localization.
  • After this PR merged, the approvers will get an github invitation for collaborate from settings[bot] of cncf/glossary. You need to accept. Please find the invitation from Email or Github notification. It the candidate dose not accept it, maintainers cannot assign you as an approver of dev-xx branch.

Signed-off-by: Seokho Son <shsongist@gmail.com>
@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 7869765
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/632858b80f668000085a0eed
😎 Deploy Preview https://deploy-preview-1324--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son seokho-son added lang/ur for Urdu maintainers Use this label if PR requires maintainers to take action hold Wait, please do not proceed this yet labels Sep 19, 2022
Signed-off-by: Seokho Son <shsongist@gmail.com>
@seokho-son seokho-son removed the hold Wait, please do not proceed this yet label Sep 20, 2022
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CathPag CathPag merged commit d1f52dd into main Sep 20, 2022
@jihoon-seo jihoon-seo deleted the add-approvers branch September 21, 2022 05:59
@jihoon-seo jihoon-seo linked an issue Sep 21, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ur for Urdu maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initiate Urdu Localization Team
3 participants