Disable TEMPLATE from sidebar of Korean site #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seokho Son <shsongist@gmail.com>
seokho-son
requested review from
Eviekim,
jihoon-seo and
yunkon-kim
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jihoon-seo
reviewed
Sep 21, 2022
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| title: 용어 정의 템플릿 | |||
| status: Completed | |||
| status: Feedback Appreciated | |||
There was a problem hiding this comment.
#1232 (comment) 에 쓰신 내용과 같이
content/ko/_TEMPLATE.md 를 삭제할 수도 있고,
또는
https://github.com/cncf/glossary/pull/1232/files#r965527390 에 쓰신 것 처럼 할 수도 있겠습니다. 😊
Suggested change
| status: Feedback Appreciated | |
| status: Feedback Appreciated (가이드: status 값은 영어 원문과 동일하게 유지) |
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> Signed-off-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Seokho Son <shsongist@gmail.com>
|
@jihoon-seo I updated PR, I think some characters for the status value are not acceptable. |
|
PTAL @yunkon-kim |
seokho-son
added a commit
to seokho-son/glossary
that referenced
this pull request
Mar 20, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Seokho Son shsongist@gmail.com
Describe your changes
Disable TEMPLATE from sidebar of Korean site.
Status: Completed makes the TEMPLATE item shown in the sidebar
Related issue number or link (ex:
resolves #issue-number)N/A
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO.