-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content/en/hypervisor #1385
Conversation
adding the term hypervisor to the glossary Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Thanks for suggesting the changes @nitishkumar06, they were relevant so I've committed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KiranSatyaRaj Thanks for the contribution. A good start, but I have some change requests and remarks :)
content/en/hypervisor.md
Outdated
A hypervisor simplifies the migration in its current state in the event of a failure on the host server. | ||
The reason for this is that it maintains snapshots of the workload so that it can be transported from one machine to another. | ||
In the context of [cloud computing](/cloud-computing/), the hypervisor becomes an effective tool. | ||
Organizations can migrate their applications to the cloud to take advantage of [cloud native apps](/cloud-native-apps/) and autoscale their services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to focus more on the setup speed and the degree of isolation between apps than on migrating for the rest of this section.
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
I'm afraid if the website contains some kind of checks where the build gets failed due to a large number of commits raised. I have no idea till now if such checks exists. In order to keep on the safer side, It could be better if @KiranSatyaRaj squash all the commits. WDYT @iamNoah1 ? |
Thanks @nitishkumar06 large number of commits does not incur build failures. But, since meaningless commits are not desired, squashing commits in a PR is desired as @nitishkumar06 suggested. Anyway, an approver will use |
removed the section that mentions the types of hypervisors Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KiranSatyaRaj please let me know whenever you have incorporated or considered the suggested feedback and if we should took a look again :)
Sure, there were a few points I mentioned in the discussion regarding the term I just wanted to check whether they were neutral and straightforward, that's fine I'll work my way through it and get back to you with the applied changes as soon as possible. |
updated the term with suggested changes, please point out what points are needed to be addressed and changes required. Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Hey @iamNoah1 I made, can you please go through it and let me know the changes required to make it better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @KiranSatyaRaj for your contribution and for your patience with all that back and forth. I think this is a good start so we will merge it as a draft. Except @CathPag objects :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for draft
* Add content/en/hypervisor adding the term hypervisor to the glossary Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update content/en/hypervisor.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update hypervisor.md removed the section that mentions the types of hypervisors Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> * Update hypervisor.md updated the term with suggested changes, please point out what points are needed to be addressed and changes required. Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com> Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Co-authored-by: Noah Ispas <Noahispas@gmail.com>
adding the term hypervisor to the glossary
Signed-off-by: Kiran Satya Raj 90622705+KiranSatyaRaj@users.noreply.github.com
Describe your changes
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.