Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content/en/hypervisor #1385

Merged
merged 15 commits into from
Nov 18, 2022
Merged

Add content/en/hypervisor #1385

merged 15 commits into from
Nov 18, 2022

Conversation

KiranSatyaRaj
Copy link
Contributor

@KiranSatyaRaj KiranSatyaRaj commented Oct 17, 2022

adding the term hypervisor to the glossary

Signed-off-by: Kiran Satya Raj 90622705+KiranSatyaRaj@users.noreply.github.com

Describe your changes

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

adding the term hypervisor to the glossary

Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 529ed21
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/636f497c1d9dc400089ce9ce
😎 Deploy Preview https://deploy-preview-1385--cncfglossary.netlify.app/hypervisor
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KiranSatyaRaj KiranSatyaRaj mentioned this pull request Oct 17, 2022
5 tasks
@jihoon-seo jihoon-seo linked an issue Oct 18, 2022 that may be closed by this pull request
5 tasks
@jihoon-seo jihoon-seo added the lang/en for English label Oct 18, 2022
content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
KiranSatyaRaj and others added 3 commits October 19, 2022 09:55
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
@KiranSatyaRaj
Copy link
Contributor Author

Thanks for suggesting the changes @nitishkumar06, they were relevant so I've committed them.

@iamNoah1 iamNoah1 self-assigned this Oct 20, 2022
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KiranSatyaRaj Thanks for the contribution. A good start, but I have some change requests and remarks :)

content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
content/en/hypervisor.md Outdated Show resolved Hide resolved
A hypervisor simplifies the migration in its current state in the event of a failure on the host server.
The reason for this is that it maintains snapshots of the workload so that it can be transported from one machine to another.
In the context of [cloud computing](/cloud-computing/), the hypervisor becomes an effective tool.
Organizations can migrate their applications to the cloud to take advantage of [cloud native apps](/cloud-native-apps/) and autoscale their services.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to focus more on the setup speed and the degree of isolation between apps than on migrating for the rest of this section.

KiranSatyaRaj and others added 9 commits October 28, 2022 16:02
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
@nitishfy
Copy link
Contributor

nitishfy commented Oct 29, 2022

I'm afraid if the website contains some kind of checks where the build gets failed due to a large number of commits raised. I have no idea till now if such checks exists. In order to keep on the safer side, It could be better if @KiranSatyaRaj squash all the commits. WDYT @iamNoah1 ?

@seokho-son
Copy link
Collaborator

Thanks @nitishkumar06

large number of commits does not incur build failures. But, since meaningless commits are not desired, squashing commits in a PR is desired as @nitishkumar06 suggested.
By the way, contributor doesn't have to keep squashing or amending commits for every PR updates. The squashing can be done by contributor just before this PR is ready to be merged.

Anyway, an approver will use squash and merge method to merge this PR.

removed the section that mentions the types of hypervisors

Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KiranSatyaRaj please let me know whenever you have incorporated or considered the suggested feedback and if we should took a look again :)

@KiranSatyaRaj
Copy link
Contributor Author

@KiranSatyaRaj please let me know whenever you have incorporated or considered the suggested feedback and if we should took a look again :)

Sure, there were a few points I mentioned in the discussion regarding the term I just wanted to check whether they were neutral and straightforward, that's fine I'll work my way through it and get back to you with the applied changes as soon as possible.

content/en/hypervisor.md Outdated Show resolved Hide resolved
updated the term with suggested changes, please point out what points are needed to be addressed and changes required.

Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
@KiranSatyaRaj KiranSatyaRaj requested review from iamNoah1 and seokho-son and removed request for iamNoah1 and seokho-son November 12, 2022 07:21
@KiranSatyaRaj
Copy link
Contributor Author

KiranSatyaRaj commented Nov 13, 2022

Hey @iamNoah1 I made, can you please go through it and let me know the changes required to make it better.

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @KiranSatyaRaj for your contribution and for your patience with all that back and forth. I think this is a good start so we will merge it as a draft. Except @CathPag objects :)

Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for draft

@iamNoah1 iamNoah1 merged commit 54f38c9 into cncf:main Nov 18, 2022
@KiranSatyaRaj KiranSatyaRaj deleted the patch-2 branch November 19, 2022 11:16
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
* Add content/en/hypervisor

adding the term hypervisor to the glossary

Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update content/en/hypervisor.md

Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update hypervisor.md

removed the section that mentions the types of hypervisors

Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

* Update hypervisor.md

updated the term with suggested changes, please point out what points are needed to be addressed and changes required.

Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>

Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New term] Hypervisor
6 participants