Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev-it approver #1437

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Update dev-it approver #1437

merged 2 commits into from
Nov 16, 2022

Conversation

seokho-son
Copy link
Collaborator

@seokho-son seokho-son commented Nov 4, 2022

Signed-off-by: Seokho Son shsongist@gmail.com

Describe your changes

  • Update dev-it approvers

Related issue number or link

Based on the following request from the Italian team.

This PR replace existing approver with a new approver for dev-it

  • Commitment from the new approver @ugho16
  • Commitment (or lazy consensus) from the released approver @meryem-ldn

Important

  • All new candidates need to leave a comment in this PR that you understood the following policies and information. (l10n teams: please share this message to candidates)
  • The l10n team approvers need to use your permission appropriately.
    • The approvers of l10n team will have a push permission to this repository.
      It is to make l10n approvers manage (merge) PRs for l10n contributions in your development branch.
      Merging a PR to the main branch by l10n approvers is restricted.
      Even if they are possible to review a PR to the main branch and give an approval to the PR, they should not approve the PR.
      So, please do not approve if a PR is not related with your localization.
  • After this PR merged, the approvers will get an github invitation for collaborate from settings[bot] of cncf/glossary. You need to accept. Please find the invitation from Email or Github notification. It the candidate does not accept it, maintainers cannot assign you as an approver of dev-xx branch.

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO.

Signed-off-by: Seokho Son <shsongist@gmail.com>
@netlify
Copy link

netlify bot commented Nov 4, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 10777c9
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6364d39c1535cb000859e845
😎 Deploy Preview https://deploy-preview-1437--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Seokho Son <shsongist@gmail.com>
@seokho-son seokho-son added lang/it for Italian maintainers Use this label if PR requires maintainers to take action labels Nov 4, 2022
@seokho-son seokho-son mentioned this pull request Nov 4, 2022
1 task
@ugho16
Copy link
Collaborator

ugho16 commented Nov 4, 2022

Hi @seokho-son, thank you for this PR.
I read and understood all the information you shared.

@seokho-son
Copy link
Collaborator Author

@jihoon-seo @CathPag @iamNoah1
Maintainers ~ !

I think this PR is ready to be merged.

@jihoon-seo jihoon-seo merged commit 78c04da into cncf:main Nov 16, 2022
seokho-son added a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/it for Italian maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants