Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change api absolute reference #1441

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

electrocucaracha
Copy link
Collaborator

Describe your changes

The Event streaming definition contains an absolute reference to the API term, this exception doesn't match with the rest of the terms.

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Victor Morales <v.morales@samsung.com>
@netlify
Copy link

netlify bot commented Nov 4, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 8ea8d32
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6365500c45888f0008702e53
😎 Deploy Preview https://deploy-preview-1441--cncfglossary.netlify.app/event-streaming
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks~!

@jihoon-seo jihoon-seo merged commit 1f67e2c into cncf:main Nov 7, 2022
@electrocucaracha electrocucaracha deleted the fix-reference branch November 7, 2022 22:20
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
Signed-off-by: Victor Morales <v.morales@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants