Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable labeler to non-korean languages #1442

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

electrocucaracha
Copy link
Collaborator

Describe your changes

The labeler task helps to organize PR based on the folder where the changes happen. This logic needs to be applied to all languages.

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Victor Morales <v.morales@samsung.com>
@netlify
Copy link

netlify bot commented Nov 4, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit f2a197c
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/637998799d27620008d89468
😎 Deploy Preview https://deploy-preview-1442--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Collaborator

Hi @electrocucaracha
:)

We need this PR soon, but I am not sure when to apply.
Current condition for the branch is intentional for testing and to prevent a workflow failure by labeling.

PTAL #1322

If we apply this PR, all branches (dev-xx) have to be updated accordingly. So, all teams need to be cooperated.

(cc @yunkon-kim )

@seokho-son
Copy link
Collaborator

Let's bring this issue to the next Glossary working group meeting :)

Copy link
Collaborator

@yunkon-kim yunkon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @electrocucaracha (CC @seokho-son)

I think it is better to specify the target branch explicitly than delete it.

pull_request_target has write permission so we have to be careful using it.

.github/workflows/labeler.yml Show resolved Hide resolved
Co-authored-by: Yunkon Kim <hermitkim1@gmail.com>
Signed-off-by: Victor Morales <chipahuac@hotmail.com>
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hi @jihoon-seo
I'd like to merge this PR and disable labeler workflow manually until all dev-xx branches apply this change. (I will check update of all dev-xx branches)

Please approve :)

@jihoon-seo jihoon-seo added the maintainers Use this label if PR requires maintainers to take action label Dec 13, 2022
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all!

@seokho-son seokho-son merged commit 95a40cf into cncf:main Dec 13, 2022
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
* Remove branch criteria selection in labeler CI

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Update branches

Co-authored-by: Yunkon Kim <hermitkim1@gmail.com>
Signed-off-by: Victor Morales <chipahuac@hotmail.com>

Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Yunkon Kim <hermitkim1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants