-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable labeler to non-korean languages #1442
Conversation
Signed-off-by: Victor Morales <v.morales@samsung.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @electrocucaracha We need this PR soon, but I am not sure when to apply. PTAL #1322 If we apply this PR, all branches (dev-xx) have to be updated accordingly. So, all teams need to be cooperated. (cc @yunkon-kim ) |
Let's bring this issue to the next Glossary working group meeting :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @electrocucaracha (CC @seokho-son)
I think it is better to specify the target branch explicitly than delete it.
pull_request_target
has write permission so we have to be careful using it.
Co-authored-by: Yunkon Kim <hermitkim1@gmail.com> Signed-off-by: Victor Morales <chipahuac@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @jihoon-seo
I'd like to merge this PR and disable labeler workflow manually until all dev-xx branches apply this change. (I will check update of all dev-xx branches)
Please approve :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all!
* Remove branch criteria selection in labeler CI Signed-off-by: Victor Morales <v.morales@samsung.com> * Update branches Co-authored-by: Yunkon Kim <hermitkim1@gmail.com> Signed-off-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Victor Morales <v.morales@samsung.com> Signed-off-by: Victor Morales <chipahuac@hotmail.com> Co-authored-by: Yunkon Kim <hermitkim1@gmail.com>
Describe your changes
The labeler task helps to organize PR based on the folder where the changes happen. This logic needs to be applied to all languages.
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.