Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Localize Serverless for Hindi #1443

Merged
merged 15 commits into from
Jun 28, 2023
Merged

[hi] Localize Serverless for Hindi #1443

merged 15 commits into from
Jun 28, 2023

Conversation

shivam-sharma7
Copy link
Contributor

Serverless now Localized into Hindi.

Signed-off-by: Shivam Sharma meshivam81@gmail.com

Related issue- #1435

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit cbef1cc
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6444058959280f000876d51b
😎 Deploy Preview https://deploy-preview-1443--cncfglossary.netlify.app/hi/serverless
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shivam-sharma7
Copy link
Contributor Author

review/ @nitishkumar06 @anubha-v-ardhan

@jihoon-seo jihoon-seo added the lang/hi for Hindi label Nov 7, 2022
@jihoon-seo jihoon-seo linked an issue Nov 7, 2022 that may be closed by this pull request
@shivam-sharma7
Copy link
Contributor Author

review/ @Garima-Negi

content/hi/serverless.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall suggestion:

The content is well written. However, before merging this PR, I'd like to know what @Garima-Negi & @anubha-v-ardhan have to say about this.

Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
@shivam-sharma7
Copy link
Contributor Author

review/ @Garima-Negi

Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits

content/hi/serverless.md Outdated Show resolved Hide resolved
content/hi/serverless.md Outdated Show resolved Hide resolved
content/hi/serverless.md Outdated Show resolved Hide resolved
content/hi/serverless.md Outdated Show resolved Hide resolved
content/hi/serverless.md Outdated Show resolved Hide resolved
content/hi/serverless.md Outdated Show resolved Hide resolved
content/hi/serverless.md Outdated Show resolved Hide resolved
shivam-sharma7 and others added 7 commits April 22, 2023 21:33
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jayesh-srivastava jayesh-srivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anubha-v-ardhan anubha-v-ardhan changed the base branch from main to dev-hi June 28, 2023 18:22
@anubha-v-ardhan anubha-v-ardhan merged commit aa5f586 into cncf:dev-hi Jun 28, 2023
@shivam-sharma7 shivam-sharma7 deleted the serverless-hi branch June 29, 2023 00:31
@shivam-sharma7
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hi] Localize Serverless for Hindi
5 participants