-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hi] Localize Serverless
for Hindi
#1443
Conversation
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
review/ @nitishkumar06 @anubha-v-ardhan |
review/ @Garima-Negi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall suggestion:
The content is well written. However, before merging this PR, I'd like to know what @Garima-Negi & @anubha-v-ardhan have to say about this.
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
review/ @Garima-Negi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com> Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com> Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com> Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com> Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com> Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com> Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com> Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks |
Serverless
now Localized into Hindi.Signed-off-by: Shivam Sharma meshivam81@gmail.com
Related issue- #1435
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.