Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spanish] localize 'Digital Certificate #1499

Merged
merged 7 commits into from
Dec 13, 2022

Conversation

vasucp1207
Copy link
Contributor

Signed-off-by: Vasu Singh vasucp1207@gmail.com

Describe your changes

[Spanish] localize 'Digital Certificate

Related issue #1371

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit e27be97
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/638f904baa6fc900094d9e8d
😎 Deploy Preview https://deploy-preview-1499--cncfglossary.netlify.app/es/digital-certificate
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son seokho-son added the lang/es for Spanish label Nov 29, 2022
content/es/digital-certificate.md Outdated Show resolved Hide resolved
content/es/digital-certificate.md Outdated Show resolved Hide resolved
content/es/digital-certificate.md Outdated Show resolved Hide resolved
content/es/digital-certificate.md Outdated Show resolved Hide resolved
content/es/digital-certificate.md Outdated Show resolved Hide resolved
content/es/digital-certificate.md Outdated Show resolved Hide resolved
content/es/digital-certificate.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @vasucp1207 Please fix the Spellcheck, you need to add the word ssl

@vasucp1207
Copy link
Contributor Author

lgtm! @vasucp1207 Please fix the Spellcheck, you need to add the word ssl

I do not get it can you please specify more about it?

@electrocucaracha
Copy link
Collaborator

lgtm! @vasucp1207 Please fix the Spellcheck, you need to add the word ssl

I do not get it can you please specify more about it?

There is a CI task that checks for spelling errors in the Spanish content. The task extends its internal dictionary with more words defined in this list. This PR requires the addition of new words in that list, otherwise CI task won't pass

Could you include those words into that file? And also make sure that they are added in alphabetical order.

@vasucp1207 vasucp1207 mentioned this pull request Dec 5, 2022
2 tasks
@vasucp1207
Copy link
Contributor Author

@electrocucaracha, I updated the wordlist file when that merges then I also update this PR.

@electrocucaracha
Copy link
Collaborator

@electrocucaracha, I updated the wordlist file when that merges then I also update this PR.

You have to include those changes in this PR to make the Spellchecker CI pass.

@vasucp1207 vasucp1207 force-pushed the patch-3 branch 7 times, most recently from 6887496 to 3dff80c Compare December 5, 2022 21:38
anairinac and others added 6 commits December 5, 2022 21:45
Signed-off-by: Irina Calvo <anairinac@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
@vasucp1207
Copy link
Contributor Author

@electrocucaracha, check now.

content/es/digital-certificate.md Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Quiceno B <nicolas.quiceno@astrokube.com>
Signed-off-by: Vasu Singh <vasucp1207@gmail.com>
@vasucp1207 vasucp1207 requested review from 92nqb, electrocucaracha and krol3 and removed request for electrocucaracha, 92nqb and krol3 December 6, 2022 18:57
Copy link
Collaborator

@92nqb 92nqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@electrocucaracha electrocucaracha merged commit cc17ca6 into cncf:dev-es Dec 13, 2022
ramrodo pushed a commit to ramrodo/glossary that referenced this pull request Dec 13, 2022
* Update content/es/digital-certificate.md

Signed-off-by: Vasu Singh <vasucp1207@gmail.com>
Co-authored-by: Nicolas Quiceno B <nicolas.quiceno@astrokube.com>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
* Update content/es/digital-certificate.md

Signed-off-by: Vasu Singh <vasucp1207@gmail.com>
Co-authored-by: Nicolas Quiceno B <nicolas.quiceno@astrokube.com>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
* Update content/es/digital-certificate.md

Signed-off-by: Vasu Singh <vasucp1207@gmail.com>
Co-authored-by: Nicolas Quiceno B <nicolas.quiceno@astrokube.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/es for Spanish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants