-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spanish] localize 'Digital Certificate #1499
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! @vasucp1207 Please fix the Spellcheck, you need to add the word ssl
I do not get it can you please specify more about it? |
There is a CI task that checks for spelling errors in the Spanish content. The task extends its internal dictionary with more words defined in this list. This PR requires the addition of new words in that list, otherwise CI task won't pass Could you include those words into that file? And also make sure that they are added in alphabetical order. |
@electrocucaracha, I updated the wordlist file when that merges then I also update this PR. |
You have to include those changes in this PR to make the Spellchecker CI pass. |
6887496
to
3dff80c
Compare
Signed-off-by: Irina Calvo <anairinac@gmail.com> Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
Signed-off-by: vasucp1207 <vasucp1207@gmail.com>
@electrocucaracha, check now. |
Co-authored-by: Nicolas Quiceno B <nicolas.quiceno@astrokube.com> Signed-off-by: Vasu Singh <vasucp1207@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Update content/es/digital-certificate.md Signed-off-by: Vasu Singh <vasucp1207@gmail.com> Co-authored-by: Nicolas Quiceno B <nicolas.quiceno@astrokube.com>
* Update content/es/digital-certificate.md Signed-off-by: Vasu Singh <vasucp1207@gmail.com> Co-authored-by: Nicolas Quiceno B <nicolas.quiceno@astrokube.com>
* Update content/es/digital-certificate.md Signed-off-by: Vasu Singh <vasucp1207@gmail.com> Co-authored-by: Nicolas Quiceno B <nicolas.quiceno@astrokube.com>
Signed-off-by: Vasu Singh vasucp1207@gmail.com
Describe your changes
[Spanish] localize 'Digital Certificate
Related issue #1371
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.