-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add api-gateway-hindi.md #1614
Add api-gateway-hindi.md #1614
Conversation
Signed-off-by: Aniket Shitole <91371143+AniketNS@users.noreply.github.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AniketNS Thank you for your contribution.
But please:
- rename the file from
content/hi/api-gateway-hindi.md
tocontent/hi/api-gateway.md
. - change the target branch to
dev-hi
, notmain
.
(to do so, first you will need to branch off your feature branch fromdev-hi
, notmain
.)
FYI: This PR resolves #1540.
Signed-off-by: Aniket Shitole <91371143+AniketNS@users.noreply.github.com>
Rename api-gateway-hindi.md to api-gateway.md
Hello @jihoon-seo, I've made the changes please check and tell me if you want something else. |
content/hi/api-gateway.md
Outdated
|
||
## समाधान | ||
|
||
एक एप्लिकेशन में विभिन्न एपीआय के लिए एक एकल पहुंच बिंदु प्रदान करना, एपीआय गेटवे संगठनों के लिए एक केंद्रीय स्थान में क्रॉस-कटिंग व्यवसाय या सुरक्षा तर्क को लागू करना आसान बनाता है। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
एक एप्लिकेशन में विभिन्न एपीआय के लिए एक एकल पहुंच बिंदु प्रदान करना, एपीआय गेटवे संगठनों के लिए एक केंद्रीय स्थान में क्रॉस-कटिंग व्यवसाय या सुरक्षा तर्क को लागू करना आसान बनाता है। | |
एक एप्लिकेशन में विभिन्न एपीआइ के लिए एक एकल पहुंच बिंदु प्रदान करना, एपीआइ गेटवे संगठनों के लिए एक केंद्रीय स्थान में क्रॉस-कटिंग व्यवसाय या सुरक्षा को लागू करना आसान बनाता है। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@AniketNS friendly ping for implementing suggested changes on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you Resolved all the issues in this PR? if not, then resolve first and make changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the suggested changes. Please check and let me know if there are any other corrections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me
@AniketNS DCO checks of this PR is failing, can you fix it?
(Till DCO checks are not passed)
/hold
Wait, please do not proceed with this yet. |
Can you please tell me, how can I do that? |
Squash your commits, and while squashing add "Signed-off-by: Aniket Shitole 91371143+AniketNS@users.noreply.github.com" as commit description and while commiting use "git commit -s -m 'message'" |
Signed-off-by: Aniket Shitole 91371143+AniketNS@users.noreply.github.com
Describe your changes
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.