Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api-gateway-hindi.md #1614

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Add api-gateway-hindi.md #1614

merged 6 commits into from
Dec 12, 2023

Conversation

AniketNS
Copy link
Contributor

@AniketNS AniketNS commented Jan 11, 2023

Signed-off-by: Aniket Shitole 91371143+AniketNS@users.noreply.github.com

Describe your changes

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Aniket Shitole <91371143+AniketNS@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit cf8ce1c
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6552ec5132e498000855071b
😎 Deploy Preview https://deploy-preview-1614--cncfglossary.netlify.app/hi/api-gateway
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AniketNS Thank you for your contribution.
But please:

  • rename the file from content/hi/api-gateway-hindi.md to content/hi/api-gateway.md .
  • change the target branch to dev-hi, not main.
    (to do so, first you will need to branch off your feature branch from dev-hi, not main.)

FYI: This PR resolves #1540.

@jihoon-seo jihoon-seo linked an issue Feb 7, 2023 that may be closed by this pull request
Signed-off-by: Aniket Shitole <91371143+AniketNS@users.noreply.github.com>
Rename api-gateway-hindi.md to api-gateway.md
@AniketNS
Copy link
Contributor Author

AniketNS commented Feb 7, 2023

Hello @jihoon-seo, I've made the changes please check and tell me if you want something else.

@jihoon-seo jihoon-seo mentioned this pull request Feb 17, 2023
2 tasks
content/hi/api-gateway.md Outdated Show resolved Hide resolved
content/hi/api-gateway.md Outdated Show resolved Hide resolved
content/hi/api-gateway.md Outdated Show resolved Hide resolved
content/hi/api-gateway.md Outdated Show resolved Hide resolved
content/hi/api-gateway.md Outdated Show resolved Hide resolved

## समाधान

एक एप्लिकेशन में विभिन्न एपीआय के लिए एक एकल पहुंच बिंदु प्रदान करना, एपीआय गेटवे संगठनों के लिए एक केंद्रीय स्थान में क्रॉस-कटिंग व्यवसाय या सुरक्षा तर्क को लागू करना आसान बनाता है।
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
एक एप्लिकेशन में विभिन्न एपीआय के लिए एक एकल पहुंच बिंदु प्रदान करना, एपीआय गेटवे संगठनों के लिए एक केंद्रीय स्थान में क्रॉस-कटिंग व्यवसाय या सुरक्षा तर्क को लागू करना आसान बनाता है।
एक एप्लिकेशन में विभिन्न एपीआइ के लिए एक एकल पहुंच बिंदु प्रदान करना, एपीआइ गेटवे संगठनों के लिए एक केंद्रीय स्थान में क्रॉस-कटिंग व्यवसाय या सुरक्षा को लागू करना आसान बनाता है।

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

content/hi/api-gateway.md Outdated Show resolved Hide resolved
@anubha-v-ardhan anubha-v-ardhan changed the base branch from main to dev-hi June 28, 2023 14:42
@aj11anuj
Copy link
Collaborator

aj11anuj commented Oct 8, 2023

@AniketNS friendly ping for implementing suggested changes on this PR

Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you Resolved all the issues in this PR? if not, then resolve first and make changes!

@aj11anuj aj11anuj mentioned this pull request Nov 9, 2023
2 tasks
Copy link
Contributor Author

@AniketNS AniketNS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the suggested changes. Please check and let me know if there are any other corrections.

content/hi/api-gateway.md Outdated Show resolved Hide resolved
content/hi/api-gateway.md Outdated Show resolved Hide resolved
content/hi/api-gateway.md Outdated Show resolved Hide resolved
content/hi/api-gateway.md Outdated Show resolved Hide resolved
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

@AniketNS DCO checks of this PR is failing, can you fix it?
(Till DCO checks are not passed)
/hold

@aj11anuj aj11anuj added the hold Wait, please do not proceed this yet label Nov 16, 2023
Copy link

Wait, please do not proceed with this yet.

@AniketNS
Copy link
Contributor Author

Changes looks good to me

@AniketNS DCO checks of this PR is failing, can you fix it? (Till DCO checks are not passed) /hold

Can you please tell me, how can I do that?

@aj11anuj
Copy link
Collaborator

aj11anuj commented Nov 16, 2023

Squash your commits, and while squashing add "Signed-off-by: Aniket Shitole 91371143+AniketNS@users.noreply.github.com" as commit description and while commiting use "git commit -s -m 'message'"
.

@aj11anuj aj11anuj merged commit aaff350 into cncf:dev-hi Dec 12, 2023
5 checks passed
@AniketNS AniketNS deleted the patch-1 branch January 1, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hi] Localize API Gateway for Hindi
6 participants