Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Localize application-programming-interface.md to Hindi #1632

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

SaxenaAnushka102
Copy link
Contributor

Signed-off-by: ANUSHKA SAXENA anushkasaxena102@gmail.com

Describe your changes

Created a file called application-programming-interface.md to localize the page: https://glossary.cncf.io/application-programming-interface/ into Hindi

Related issue number or link

Resolves #1624

Checklist before opening this PR

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Created a file called application-programming-interface.md to localize the page: https://glossary.cncf.io/application-programming-interface/ into Hindi
Resolves cncf#1624

Signed-off-by: ANUSHKA SAXENA <anushkasaxena102@gmail.com>
@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 0bc50a4
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6550603415bcc60008dd0ad1
😎 Deploy Preview https://deploy-preview-1632--cncfglossary.netlify.app/hi/application-programming-interface
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
@anubha-v-ardhan anubha-v-ardhan changed the base branch from main to dev-hi June 28, 2023 14:57
@anubha-v-ardhan
Copy link
Contributor

Hey @SaxenaAnushka102, DCO check is failing on this PR which most probably mean commits are not properly signed. You can view more detail here. Kindly fix the issue if possible, so we can proceed with approval.

@SaxenaAnushka102 SaxenaAnushka102 force-pushed the patch-1 branch 4 times, most recently from 69daa2c to f7e1e25 Compare July 6, 2023 17:38
Signed-off-by: ANUSHKA SAXENA <anushkasaxena102@gmail.com>
@SaxenaAnushka102
Copy link
Contributor Author

Hi @anubha-v-ardhan! I've tried my best to resolve the failed check & update the requested changes. Please let me know if any further changes are needed here.

Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side

content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
content/hi/application-programming-interface.md Outdated Show resolved Hide resolved
Signed-off-by: Anuj Tiwari <aj11anuj123@gmail.com>
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Nov 12, 2023
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fixed here

@aj11anuj aj11anuj removed the Awaiting/2nd-approval This PR needs another approval review label Nov 14, 2023
@aj11anuj aj11anuj merged commit 5518d00 into cncf:dev-hi Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localize Application Programming Interface (API) page in Hindi
5 participants