-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hi] Localize application-programming-interface.md to Hindi #1632
Conversation
Created a file called application-programming-interface.md to localize the page: https://glossary.cncf.io/application-programming-interface/ into Hindi Resolves cncf#1624 Signed-off-by: ANUSHKA SAXENA <anushkasaxena102@gmail.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @SaxenaAnushka102, DCO check is failing on this PR which most probably mean commits are not properly signed. You can view more detail here. Kindly fix the issue if possible, so we can proceed with approval. |
69daa2c
to
f7e1e25
Compare
Signed-off-by: ANUSHKA SAXENA <anushkasaxena102@gmail.com>
Hi @anubha-v-ardhan! I've tried my best to resolve the failed check & update the requested changes. Please let me know if any further changes are needed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions from my side
Signed-off-by: Anuj Tiwari <aj11anuj123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fixed here
Signed-off-by: ANUSHKA SAXENA anushkasaxena102@gmail.com
Describe your changes
Created a file called application-programming-interface.md to localize the page: https://glossary.cncf.io/application-programming-interface/ into Hindi
Related issue number or link
Resolves #1624
Checklist before opening this PR
git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.