Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"who can contribute" to "how to" guide #1685

Merged
merged 3 commits into from
Feb 4, 2023
Merged

"who can contribute" to "how to" guide #1685

merged 3 commits into from
Feb 4, 2023

Conversation

CathPag
Copy link
Collaborator

@CathPag CathPag commented Feb 3, 2023

Signed-off-by: Catherine Paganini 74001907+CathPag@users.noreply.github.com

Describe your changes

Adding a "who can contribute" to the "how to" guide to better set expectations

Related issue number or link (ex: resolves #issue-number)

NA

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
@CathPag CathPag added lang/en for English maintainers Use this label if PR requires maintainers to take action labels Feb 3, 2023
@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit f8344d2
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/63dd2717f195f30008bef99e
😎 Deploy Preview https://deploy-preview-1685--cncfglossary.netlify.app/contribute
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it, lgtm

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! :)

@seokho-son seokho-son merged commit ef6b7ef into main Feb 4, 2023
@jihoon-seo jihoon-seo deleted the CathPag-how-to branch February 5, 2023 23:39
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
* "who can contribute" to "how to" guide

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>

* Update _index.md

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>

* Update _index.md

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>

---------

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants