Search by Tags #1715
Merged
Search by Tags #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
cjyabraham
requested review from
caniszczyk,
CathPag,
JasonMorgan,
seokho-son,
iamNoah1 and
jihoon-seo
as code owners
seokho-son
added
the
maintainers
jihoon-seo
approved these changes
Feb 24, 2023
seokho-son
reviewed
Feb 24, 2023
Co-authored-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
|
Nice! |
thetwopct
approved these changes
Feb 24, 2023
seokho-son
approved these changes
Feb 27, 2023
This was referenced Feb 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1006.
This PR creates a universal browse by tags screen.
This screen is linked to from every tag on the site. For example, if you click on a Methodology tag, you'll go there with the Methodology tag already selected.
Finally, I've added a small "...or browse by tags" link under the regular search box.
i18n placeholders have been set up for all languages with the new labels.