Add sestegra as an fr approver #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huats
added
maintainers
huats
requested review from
caniszczyk,
CathPag,
JasonMorgan,
seokho-son,
iamNoah1 and
jihoon-seo
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jihoon-seo
reviewed
Apr 24, 2023
Signed-off-by: Christophe Sauthier <christophe.sauthier@gmail.com>
huats
force-pushed
the
add-sestegra-as-fr-approver
branch
from
cdcf83f to
2cd974c
Compare
|
LGTM! Hi @sestegra welcome to the French approver team! |
|
Hi @seokho-son, @huats |
sestegra
pushed a commit
to sestegra/glossary
that referenced
this pull request
Jun 23, 2023
Signed-off-by: Christophe Sauthier <christophe.sauthier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Given his active collaboration in French localization team, this PR recognizes the effort made by @sestegra and promotes him to the approver role.
Related issue number or link (ex:
resolves #issue-number)NA
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".