Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Localize horizontal-scaling.md to Hindi #1988

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

SaxenaAnushka102
Copy link
Contributor

Signed-off-by: ANUSHKA SAXENA anushkasaxena102@gmail.com

Describe your changes

Created a file horizontal-scaling.md to localize the page: https://glossary.cncf.io/horizontal-scaling/ into Hindi

Related issue number

Resolves #1623

Checklist before opening this PR

  • This PR does not contain plagiarism
  • I have signed off on all commits

Created a file  horizontal-scaling.md to localize the page: https://glossary.cncf.io/ horizontal-scaling/ into Hindi

Signed-off-by: ANUSHKA SAXENA <anushkasaxena102@gmail.com>
@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit c3a2411
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6550a7e578efea00088df805
😎 Deploy Preview https://deploy-preview-1988--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: ANUSHKA SAXENA <anushkasaxena102@gmail.com>
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side

content/hi/horizontal-scaling.md Outdated Show resolved Hide resolved
content/hi/horizontal-scaling.md Outdated Show resolved Hide resolved
content/hi/horizontal-scaling.md Outdated Show resolved Hide resolved
content/hi/horizontal-scaling.md Outdated Show resolved Hide resolved
content/hi/horizontal-scaling.md Outdated Show resolved Hide resolved
content/hi/horizontal-scaling.md Outdated Show resolved Hide resolved
Signed-off-by: Anuj Tiwari <aj11anuj123@gmail.com>
@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Nov 12, 2023
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, What others Approvers say?

@aj11anuj
Copy link
Collaborator

@SaxenaAnushka102 your PR is ready to get merged, but you will have to change the target branch from 'cncf: main' to 'cncf: dev-hi' branch

@SaxenaAnushka102 SaxenaAnushka102 changed the base branch from main to dev-hi November 14, 2023 17:07
@SaxenaAnushka102
Copy link
Contributor Author

I've changed the branch to dev-hi, is it fine now @aj11anuj ?
Please let me know, thanks!

@bishal7679
Copy link
Collaborator

@SaxenaAnushka102 Appreciate your effort and the work!
Just let me final review this PR and to get ready to merge

@bishal7679 bishal7679 added the hold Wait, please do not proceed this yet label Nov 14, 2023
Copy link

Wait, please do not proceed with this yet.

@bishal7679 bishal7679 removed the hold Wait, please do not proceed this yet label Nov 16, 2023
@bishal7679
Copy link
Collaborator

Thank you @SaxenaAnushka102
Its ready to merge!

@bishal7679 bishal7679 merged commit 1eb7d78 into cncf:dev-hi Nov 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting/2nd-approval This PR needs another approval review lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localise Horizontal Scaling page in hindi
4 participants