-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings and initial contents for Traditional Chinese localization #2006
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@ydFu could you invite some Traditional Chinese team members to review this PR (the localized contents) ? |
Invite the
Invite Cloud Native Taiwan User Group organizer and KCD Taiwan organizer
|
LGTM. Thank you for @ydFu 's effort and contribution. 🥇 |
Just noticed that here might be a small mistake in Netlify preview. Not sure if it's a bug. Others LGTM. Thanks @ydFu ! |
thanks for feedback,now is working |
Signed-off-by: ydFu <ader.ydfu@gmail.com>
LGTM, Thanks |
LGTM, thanks |
LGTM, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all !! :)
LGTM!
This PR is to initiate Traditional Chinese localization based on
Base and target branch of this PR is
dev-tw
which is development branch for Traditional Chinese localization.This PR includes
[languages.zh-tw]
section inconfig.toml
Since Traditional Chinese localization team owns content
/zh-tw/*
only,this PR will require approvals from upstream owners (maintainers).
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.