Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings and initial contents for Traditional Chinese localization #2006

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

ydFu
Copy link
Collaborator

@ydFu ydFu commented May 4, 2023

This PR is to initiate Traditional Chinese localization based on

This PR includes

  • [languages.zh-tw] section in config.toml
  • content/zh-tw/ directory
  • i18n/zh-tw.toml
  • Some translated documents
    • Main page
      • content/zh-tw/_index.md
    • Terms
      • "Cloud Native Technology": content/zh-tw/cloud_native_tech.md
    • Others
      • contribute: content/zh-tw/contribute/_index.md
      • style-guide: content/zh-tw/style-guide/_index.md
      • contributor-ladder: content/zh-tw/contributor-ladder/_index.md

Since Traditional Chinese localization team owns content /zh-tw/* only,
this PR will require approvals from upstream owners (maintainers).

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 287b721
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6458b46fd1b1870008a753cf
😎 Deploy Preview https://deploy-preview-2006--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ydFu
Copy link
Collaborator Author

ydFu commented May 4, 2023

image

@seokho-son
Copy link
Collaborator

Hi @ydFu

Commit sha: 57cd3d0, Author: ydFu, Committer: ydFu; The sign-off is missing.

--> you did! :) Thanks

@seokho-son
Copy link
Collaborator

seokho-son commented May 4, 2023

@ydFu could you invite some Traditional Chinese team members to review this PR (the localized contents) ?
Any contributor can review and leave a comment. :)

@ydFu
Copy link
Collaborator Author

ydFu commented May 4, 2023

Invite the zh-tw team for review and if we like it, we can leave the "LGTM" label.

Invite Cloud Native Taiwan User Group organizer and KCD Taiwan organizer

@seokho-son seokho-son added the lang/tw for Traditional Chinese label May 4, 2023
@pichuang
Copy link
Contributor

pichuang commented May 4, 2023

LGTM. Thank you for @ydFu 's effort and contribution. 🥇

@cdxvy30
Copy link
Contributor

cdxvy30 commented May 4, 2023

Screen Shot 2023-05-04 at 7 49 15 PM

Just noticed that here might be a small mistake in Netlify preview. Not sure if it's a bug. Others LGTM. Thanks @ydFu !

@ydFu
Copy link
Collaborator Author

ydFu commented May 4, 2023

Screen Shot 2023-05-04 at 7 49 15 PM

Just noticed that here might be a small mistake in Netlify preview. Not sure if it's a bug. Others LGTM. Thanks @ydFu !

thanks for feedback,now is working

image

content/zh-tw/cloud-native-tech.md Show resolved Hide resolved
content/zh-tw/style-guide/_index.md Show resolved Hide resolved
content/zh-tw/contributor-ladder/_index.md Outdated Show resolved Hide resolved
content/zh-tw/cloud-native-tech.md Show resolved Hide resolved
content/zh-tw/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-tw/contribute/_index.md Show resolved Hide resolved
content/zh-tw/style-guide/_index.md Outdated Show resolved Hide resolved
content/zh-tw/contributor-ladder/_index.md Outdated Show resolved Hide resolved
content/zh-tw/contributor-ladder/_index.md Outdated Show resolved Hide resolved
content/zh-tw/_index.md Outdated Show resolved Hide resolved
content/zh-tw/_index.md Outdated Show resolved Hide resolved
content/zh-tw/cloud-native-tech.md Show resolved Hide resolved
@hwchiu
Copy link
Collaborator

hwchiu commented May 9, 2023

LGTM, Thanks

@tsengeagle
Copy link

LGTM, thanks

@kentlin520
Copy link

LGTM, thanks.

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all !! :)

LGTM!

@seokho-son seokho-son merged commit 6dc4c45 into cncf:dev-tw May 11, 2023
@ydFu ydFu deleted the dev-tw branch May 11, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants