Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings.yml for Tr and Bn approvers #2151

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Conversation

seokho-son
Copy link
Collaborator

Describe your changes

Update branch setting to.

  1. Add dev-tr and Turkish localization approvers (external_collaborators with write) Initiate Turkish l10n team #2123
    Add: @aliok
    Add: @halil-bugol
    Add: @developer-guy
    Add: @eminalemdar

  2. Replace Bengali localization approvers. Update CODEOWNERS for Bengali branch #2100
    Remove: @Mouly22 @ikramulkayes
    Add: @Arindam200 @sajibAdhi

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Seokho Son <shsongist@gmail.com>
@netlify
Copy link

netlify bot commented Jun 16, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit d1262e7
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/648c3a8394bd350008acd63b
😎 Deploy Preview https://deploy-preview-2151--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son seokho-son added the maintainers Use this label if PR requires maintainers to take action label Jun 16, 2023
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as requested

@jihoon-seo jihoon-seo merged commit 471795a into cncf:main Jun 18, 2023
6 checks passed
hwchiu pushed a commit to hwchiu/glossary that referenced this pull request Aug 14, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants