-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tw] Add content/zh-tw/abstraction.md #2154
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @gamerslouis First of all, I'd like to thank you for your PR. Based on the principle of translating one glossary at a time, it is recommended to complete the |
Hi @gamerslouis If you are not sure about the above changes, you can go to slack #glossary-localisation-tranditional-chinese to discuss. |
Sorry, I missed the notification for this PR, and I don't have any questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Please rebase 2 commits into 1 before merging.
https://docs.github.com/en/get-started/using-git/using-git-rebase-on-the-command-line
6d5f0c0
to
4e5aea0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In accordance with the style guide set forth by the cncf/glossary,please use semantic line breaks (one sentence per line)
4e5aea0
to
500df57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended to the new line to follow the English upstream and it is easy to maintain when the subsequent English upstream changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thanks @gamerslouis
@gamerslouis |
10335ff
to
e234ca3
Compare
Add content/zh-tw/abstraction.md Signed-off-by: gamerslouis <gamerslouis@gmail.com> Co-Authored-By: Phil Huang <phil.huang@microsoft.com>
e234ca3
to
1605696
Compare
Describe your changes
Origin content from https://glossary.cncf.io/abstraction/
Related issue number or link (ex:
resolves #issue-number
)resolves #2152
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.