Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Add content/zh-tw/abstraction.md #2154

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

gamerslouis
Copy link
Contributor

Describe your changes

Origin content from https://glossary.cncf.io/abstraction/

Related issue number or link (ex: resolves #issue-number)

resolves #2152

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 1605696
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64e1b9a3d4446d0008de48b4
😎 Deploy Preview https://deploy-preview-2154--cncfglossary.netlify.app/zh-tw/abstraction
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jihoon-seo jihoon-seo added the lang/tw for Traditional Chinese label Jun 18, 2023
@jihoon-seo jihoon-seo linked an issue Jun 18, 2023 that may be closed by this pull request
@ydFu ydFu changed the title Add content/zh-tw/abstraction.md [tw ]Add content/zh-tw/abstraction.md Jun 21, 2023
@ydFu ydFu changed the title [tw ]Add content/zh-tw/abstraction.md [tw] Add content/zh-tw/abstraction.md Jun 21, 2023
@pichuang
Copy link
Contributor

pichuang commented Jul 3, 2023

Hi @gamerslouis First of all, I'd like to thank you for your PR. Based on the principle of translating one glossary at a time, it is recommended to complete the abstraction first before processing it to the next glossary. We hope you will complete the revision of the glossary or provide other suggestions in the next review cycle. 😃

@pichuang
Copy link
Contributor

pichuang commented Aug 2, 2023

Hi @gamerslouis If you are not sure about the above changes, you can go to slack #glossary-localisation-tranditional-chinese to discuss.

@gamerslouis
Copy link
Contributor Author

Hi @gamerslouis If you are not sure about the above changes, you can go to slack #glossary-localisation-tranditional-chinese to discuss.

Sorry, I missed the notification for this PR, and I don't have any questions!

Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In accordance with the style guide set forth by the cncf/glossary,please use semantic line breaks (one sentence per line)

content/zh-tw/abstraction.md Outdated Show resolved Hide resolved
content/zh-tw/abstraction.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to the new line to follow the English upstream and it is easy to maintain when the subsequent English upstream changes.

content/zh-tw/abstraction.md Outdated Show resolved Hide resolved
content/zh-tw/abstraction.md Outdated Show resolved Hide resolved
content/zh-tw/abstraction.md Outdated Show resolved Hide resolved
content/zh-tw/abstraction.md Outdated Show resolved Hide resolved
content/zh-tw/abstraction.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks @gamerslouis

@ydFu
Copy link
Collaborator

ydFu commented Aug 15, 2023

lgtm. Please rebase 2 commits into 1 before merging.

https://docs.github.com/en/get-started/using-git/using-git-rebase-on-the-command-line

@gamerslouis
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.

@pichuang pichuang force-pushed the dev-tw-abstraction branch from 10335ff to e234ca3 Compare August 20, 2023 06:58
Add content/zh-tw/abstraction.md

Signed-off-by: gamerslouis <gamerslouis@gmail.com>
Co-Authored-By: Phil Huang <phil.huang@microsoft.com>
@pichuang pichuang force-pushed the dev-tw-abstraction branch from e234ca3 to 1605696 Compare August 20, 2023 06:58
@pichuang pichuang merged commit 4a131a2 into cncf:dev-tw Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tw] Localize Abstraction for Traditional Chinese
5 participants