[EN] update Virtualization #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
guillaumebernard84
requested review from
caniszczyk,
CathPag,
JasonMorgan,
seokho-son,
iamNoah1,
jihoon-seo,
nate-double-u and
castrojo
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guillaumebernard84
changed the title
Virtualization for En
nate-double-u
changed the title
Virtualization for En
|
Thanks for this @guillaumebernard84, I agree this sentence is unneeded. |
nate-double-u
approved these changes
Jun 30, 2023
|
I just updated the description to make sure this PR was linked to the issue. |
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/glossary
that referenced
this pull request
Jul 8, 2023
* [en] Virtualization - remove redundant sentence Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr> * [en] Virtualization - remove redundant sentence Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr> --------- Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr> Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
hwchiu
pushed a commit
to hwchiu/glossary
that referenced
this pull request
Aug 14, 2023
* [en] Virtualization - remove redundant sentence Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr> * [en] Virtualization - remove redundant sentence Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr> --------- Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I think the last sentence from the "How it helps" paragraph doesn't make sense: "VMs also enable users to speed up the time to get a new virtual computer". Without VMs, you cannot get a new virtual computer at all. We could fix this sentence, but then it would be redundant with the previous one in the same paragraph. I suggest to remove it.
Related issue number or link (ex:
resolves #issue-number)Fixes #2143
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".