-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Remove links to 'Deprecated' / 'Feedback Appreciated' terms #2219
Merged
huats
merged 4 commits into
cncf:dev-fr
from
guillaumebernard84:fr-contenairization-remove-link
Jul 15, 2023
Merged
[FR] Remove links to 'Deprecated' / 'Feedback Appreciated' terms #2219
huats
merged 4 commits into
cncf:dev-fr
from
guillaumebernard84:fr-contenairization-remove-link
Jul 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
guillaumebernard84
requested review from
huats,
fydrah,
Krast76 and
sestegra
as code owners
July 11, 2023 20:30
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sestegra
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
huats
reviewed
Jul 12, 2023
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
…guillaumebernard84/glossary into fr-contenairization-remove-link Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Il me semble que les modifications sont correctes. Je réouvre le PR. |
huats
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Following this PR, doing the same for the not merged yet FR branch : #2198
Only one occurence found
Related issue number or link (ex:
resolves #issue-number
)#2198
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.