-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tr] Add website config for Turkish #2235
Conversation
Signed-off-by: Ali Ok <aliok@redhat.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ali Ok <aliok@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Converted to a draft to hold this PR. We're running a poll for a possible better translation of a term. |
Signed-off-by: Ali Ok <aliok@redhat.com>
Changed one word as we voted. Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hm I thought we (TR approvers) would be able to merge to this branch ourselves @seokho-son . Do we need your approval? |
@aliok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment. :)
the other parts looks good to me!
Please utilize the 'Squash and merge' method when merging a localization pull request (PR). While not mandatory, we strongly encourage you to make an effort to keep the commit history clean. In case the commit history in the development branch is not well-maintained, the maintainers would squash the commits into a single one when merging the development branch into the main branch. :) |
Co-authored-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Ali Ok <aliok@redhat.com>
Got it. Thanks |
* Add Turkish config for the website Signed-off-by: Ali Ok <aliok@redhat.com> * Fix config.toml Signed-off-by: Ali Ok <aliok@redhat.com> * Change "Lügat" to "Sözlük" Signed-off-by: Ali Ok <aliok@redhat.com> * Update config.toml Co-authored-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Ali Ok <aliok@redhat.com> --------- Signed-off-by: Ali Ok <aliok@redhat.com> Co-authored-by: Seokho Son <shsongist@gmail.com>
* Add Turkish config for the website Signed-off-by: Ali Ok <aliok@redhat.com> * Fix config.toml Signed-off-by: Ali Ok <aliok@redhat.com> * Change "Lügat" to "Sözlük" Signed-off-by: Ali Ok <aliok@redhat.com> * Update config.toml Co-authored-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Ali Ok <aliok@redhat.com> --------- Signed-off-by: Ali Ok <aliok@redhat.com> Co-authored-by: Seokho Son <shsongist@gmail.com>
* Add Turkish config for the website Signed-off-by: Ali Ok <aliok@redhat.com> * Fix config.toml Signed-off-by: Ali Ok <aliok@redhat.com> * Change "Lügat" to "Sözlük" Signed-off-by: Ali Ok <aliok@redhat.com> * Update config.toml Co-authored-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Ali Ok <aliok@redhat.com> --------- Signed-off-by: Ali Ok <aliok@redhat.com> Co-authored-by: Seokho Son <shsongist@gmail.com>
Describe your changes
config.toml
for Turkishi18n/tr.toml
file for the common UI text translationGoogle Docs for reference:
i18n/tr.toml
config.toml
Preview: https://deploy-preview-2235--cncfglossary.netlify.app/tr/
(all empty right now)
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.