Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tr] Add website config for Turkish #2235

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

aliok
Copy link
Member

@aliok aliok commented Jul 17, 2023

Describe your changes

  • Added a section in config.toml for Turkish
  • Added a i18n/tr.toml file for the common UI text translation

Google Docs for reference:

Preview: https://deploy-preview-2235--cncfglossary.netlify.app/tr/
(all empty right now)

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Ali Ok <aliok@redhat.com>
@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 5693e59
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64b78b1d78c51c0008b8a200
😎 Deploy Preview https://deploy-preview-2235--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aliok aliok changed the base branch from main to dev-tr July 17, 2023 13:50
@aliok
Copy link
Member Author

aliok commented Jul 17, 2023

Signed-off-by: Ali Ok <aliok@redhat.com>
Copy link

@halil-bugol halil-bugol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@aliok aliok marked this pull request as draft July 17, 2023 14:11
@aliok
Copy link
Member Author

aliok commented Jul 17, 2023

Converted to a draft to hold this PR. We're running a poll for a possible better translation of a term.

@jihoon-seo jihoon-seo added the lang/tr for Turkish label Jul 18, 2023
Signed-off-by: Ali Ok <aliok@redhat.com>
@aliok aliok marked this pull request as ready for review July 18, 2023 14:21
@aliok
Copy link
Member Author

aliok commented Jul 18, 2023

Changed one word as we voted. Ready for review!

Copy link
Collaborator

@eminalemdar eminalemdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliok
Copy link
Member Author

aliok commented Jul 18, 2023

Hm I thought we (TR approvers) would be able to merge to this branch ourselves @seokho-son . Do we need your approval?

@seokho-son
Copy link
Collaborator

@aliok
localization approvers can merge PRs to their dev branch, but it is not about codeowners.
Changing files outside /content/tr/* still requires approval from maintainers (or English approvers) even for a localization dev branch. Localization approvers probably don't want to deal with the tricky aspects of repo such as changing site configuration. ;)

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment. :)
the other parts looks good to me!

config.toml Outdated Show resolved Hide resolved
@seokho-son
Copy link
Collaborator

Please utilize the 'Squash and merge' method when merging a localization pull request (PR). While not mandatory, we strongly encourage you to make an effort to keep the commit history clean. In case the commit history in the development branch is not well-maintained, the maintainers would squash the commits into a single one when merging the development branch into the main branch. :)

Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
@aliok
Copy link
Member Author

aliok commented Jul 19, 2023

files outside /content/tr/* still requires approval from maintainers

Got it. Thanks

@aliok aliok merged commit 70a9c01 into cncf:dev-tr Jul 19, 2023
aliok added a commit to aliok/glossary that referenced this pull request Aug 16, 2023
* Add Turkish config for the website

Signed-off-by: Ali Ok <aliok@redhat.com>

* Fix config.toml

Signed-off-by: Ali Ok <aliok@redhat.com>

* Change "Lügat" to "Sözlük"

Signed-off-by: Ali Ok <aliok@redhat.com>

* Update config.toml

Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Ali Ok <aliok@redhat.com>

---------

Signed-off-by: Ali Ok <aliok@redhat.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
aliok added a commit to aliok/glossary that referenced this pull request Dec 1, 2023
* Add Turkish config for the website

Signed-off-by: Ali Ok <aliok@redhat.com>

* Fix config.toml

Signed-off-by: Ali Ok <aliok@redhat.com>

* Change "Lügat" to "Sözlük"

Signed-off-by: Ali Ok <aliok@redhat.com>

* Update config.toml

Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Ali Ok <aliok@redhat.com>

---------

Signed-off-by: Ali Ok <aliok@redhat.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
@aliok aliok deleted the 2023-07-04-tr-initial-steps branch January 12, 2024 10:19
aliok added a commit to aliok/glossary that referenced this pull request Jan 24, 2024
* Add Turkish config for the website

Signed-off-by: Ali Ok <aliok@redhat.com>

* Fix config.toml

Signed-off-by: Ali Ok <aliok@redhat.com>

* Change "Lügat" to "Sözlük"

Signed-off-by: Ali Ok <aliok@redhat.com>

* Update config.toml

Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Ali Ok <aliok@redhat.com>

---------

Signed-off-by: Ali Ok <aliok@redhat.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tr for Turkish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants