Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing sestegra for merging into dev-fr #2238

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

sestegra
Copy link
Collaborator

Describe your changes

sestegra is missing for merging into dev-fr branch

Related issue number or link (ex: resolves #issue-number)

N/A

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 17c9db6
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64b6664ac8cd050007f9c329
😎 Deploy Preview https://deploy-preview-2238--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that after this PR gets merged into main, it will take effect.

Note: @sestegra is already in https://github.com/cncf/people/blob/main/config.yaml#L525

@jihoon-seo jihoon-seo added maintainers Use this label if PR requires maintainers to take action lang/fr for French labels Jul 19, 2023
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@seokho-son seokho-son merged commit 17f5a02 into cncf:main Jul 24, 2023
@sestegra sestegra mentioned this pull request Jul 26, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/fr for French maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants