Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix whitespace and a few trivial typos #2250

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

adamdmharvey
Copy link
Contributor

@adamdmharvey adamdmharvey commented Jul 26, 2023

Describe your changes

This PR fixes some minor whitespace issues (e.g., spacing around a Markdown heading, a few trailing quotes in non-primary content), as well as fixes one typo in repo guidance and one in a trivial comment.

From a consistency perspective, almost all of the primary content in content/en/ uses spacing around Markdown headers (and most Markdown linters recommend that), so I just found a few which were lacking it so made them consistent.

Just minor editorial tweaks!

As always, love referring to this content; thanks for contributing it!

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Adam Harvey <aharvey00@gmail.com>
Signed-off-by: Adam Harvey <aharvey00@gmail.com>
Signed-off-by: Adam Harvey <aharvey00@gmail.com>
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 0c49fcb
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64c12d663793310008def45c
😎 Deploy Preview https://deploy-preview-2250--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/en for English label Jul 26, 2023
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@iamNoah1 iamNoah1 merged commit a42311b into cncf:main Jul 26, 2023
@adamdmharvey adamdmharvey deleted the adamdmharvey/editorial branch July 26, 2023 16:20
Fionn88 pushed a commit to Fionn88/glossary that referenced this pull request Sep 15, 2023
* chore: Fix whitespace issues

Signed-off-by: Adam Harvey <aharvey00@gmail.com>

* fix: Typo with double word

Signed-off-by: Adam Harvey <aharvey00@gmail.com>

* chore: Typo in comment

Signed-off-by: Adam Harvey <aharvey00@gmail.com>

---------

Signed-off-by: Adam Harvey <aharvey00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
Development

Successfully merging this pull request may close these issues.

3 participants