[tr] Update content/tr/abstraction.md #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symys
requested review from
aliok,
halil-bugol,
developer-guy and
eminalemdar
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: SeymaDemir <seymademir35@gmail.com>
aliok
reviewed
Aug 18, 2023
rwxdash
reviewed
Aug 18, 2023
content/tr/abstraction.md
Outdated
| @@ -0,0 +1,16 @@ | |||
| --- | |||
| title: Soyutlama (Abstraction) | |||
There was a problem hiding this comment.
One thing that I'm worried is that if the title is somewhat long, with the parentheses it'll be hard to read and probably won't look good. My suggestion is to keep the title in Turkish and include the English equivalent where we mention it first time in text, probably in the first paragraph.
Would love to hear your thoughts.
There was a problem hiding this comment.
I like your suggestion, makes sense.
Signed-off-by: SeymaDemir <seymademir35@gmail.com>
rwxdash
approved these changes
Aug 18, 2023
halil-bugol
approved these changes
Aug 18, 2023
aliok
pushed a commit
to aliok/glossary
that referenced
this pull request
Dec 1, 2023
* Update content/tr/abstraction.md Signed-off-by: SeymaDemir <seymademir35@gmail.com> * Update content/tr/abstraction.md Signed-off-by: SeymaDemir <seymademir35@gmail.com> --------- Signed-off-by: SeymaDemir <seymademir35@gmail.com>
aliok
pushed a commit
to aliok/glossary
that referenced
this pull request
Jan 24, 2024
* Update content/tr/abstraction.md Signed-off-by: SeymaDemir <seymademir35@gmail.com> * Update content/tr/abstraction.md Signed-off-by: SeymaDemir <seymademir35@gmail.com> --------- Signed-off-by: SeymaDemir <seymademir35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Localize "Abstraction" page into Turkish
Related issue number or link (ex:
resolves #issue-number)Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".