Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize cloud native apps for Japanese #2391

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

naonishijima
Copy link
Collaborator

@naonishijima naonishijima commented Sep 14, 2023

Describe your changes

  • Localize cloud native apps for Japanese
  • Fix category, status, markdown format

Related issue number or link (ex: resolves #issue-number)

#2114

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit be1faae
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6507ec5ffb1b9f00082c283c
😎 Deploy Preview https://deploy-preview-2391--cncfglossary.netlify.app/ja/cloud-native-apps
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/ja for Japanese label Sep 14, 2023
@yuichi-nakamura
Copy link
Collaborator

@naonishijima
It seems that this PR contains unrelated parts, such as fix of status for other items.
Could you separate them?

@naonishijima
Copy link
Collaborator Author

@yuichi-nakamura
Thank you for review.
Sorry for the inconvenience. I separated the PR.

Copy link
Collaborator

@yuichi-nakamura yuichi-nakamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com>
@naonishijima naonishijima merged commit a78d6b2 into cncf:dev-ja Sep 18, 2023
@naonishijima naonishijima deleted the dev-ja-2114 branch October 1, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants