Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectified the grammatical error and sentences in Virtualization.md #2404

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

Debaditya-Som
Copy link
Contributor

Description of the changes

This Pull Request aims to rectify the the grammatical errors present in the documentation and also changes the sentences that did not make sense before. Ref: #2403

Related issue number or link :

Closes issue : #2403

Benefits of the PR

  1. Improved Clarity: Correcting the grammatical errors in the Bengali translation will make the content more clear and comprehensible to Bengali-speaking users who visit the CNCF Glossary to understand technical terms.

  2. Enhanced Accessibility: By providing a more accurate translation, this PR will improve the accessibility of technical information for the Bengali-speaking audience, ensuring that they can access and use the content effectively.

  3. Quality Assurance: Addressing these grammatical errors reflects the commitment to maintaining high-quality translations on the CNCF Glossary, which enhances the overall credibility of the resource.

Additional Information

  • Language: Bengali

Note:
If you have proficiency in Bengali and can suggest improvements beyond the identified corrections, your input would be highly valuable.

Checklist

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Rectified the grammatical errors present in the documentation and also  changed the sentences that did not make sense before are now correct.

Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit e63c7d2
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65ca54856ce32b000825f60b
😎 Deploy Preview https://deploy-preview-2404--cncfglossary.netlify.app/bn/virtualization
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/bn for Bengali label Sep 16, 2023
@Debaditya-Som
Copy link
Contributor Author

@sajibAdhi @Arindam200 @Imtiaz1234 @mitul3737
Could you kindly review this PR.
This fixes issue: #2404

@Debaditya-Som
Copy link
Contributor Author

Debaditya-Som commented Jan 24, 2024

@Arindam200 @Imtiaz1234 @sajibAdhi @mitul3737 kindly review this PR

Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
@sajibAdhi
Copy link
Collaborator

Hey @Debaditya-Som.

Thank you for your valuable contribution! We generally update Bengali docs in the dev-bn branch. Could you kindly change the target branch from main to dev-bn?

@Debaditya-Som
Copy link
Contributor Author

Hey @Debaditya-Som.

Thank you for your valuable contribution! We generally update Bengali docs in the dev-bn branch. Could you kindly change the target branch from main to dev-bn?

yep surely

@sajibAdhi sajibAdhi changed the base branch from main to dev-bn February 1, 2024 05:37
Signed-off-by: Sajib Adhikary <60180521+sajibAdhi@users.noreply.github.com>

## এটা কিভাবে সাহায্য করে
## এটা কিভাবে সাহায্য করে ?
Copy link
Collaborator

@asem-hamid asem-hamid Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a subheading . it doesn't need ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it kindly check it

Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
@asem-hamid
Copy link
Collaborator

@Debaditya-Som do you interested in non code contribution ?

@Debaditya-Som
Copy link
Contributor Author

@Debaditya-Som do you interested in non code contribution ?

yup i'm interested in contributing whether it's coding or non-coding :)

Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
@asem-hamid
Copy link
Collaborator

@Debaditya-Som That's great . We have another cncf localization project , check it out here

Kubernetes website to Bengali

If you interested you can join our Slack

@Debaditya-Som
Copy link
Contributor Author

@Debaditya-Som That's great . We have another cncf localization project , check it out here

Kubernetes website to Bengali

If you interested you can join our Slack

Yep surely I'm interested in this :)

@asem-hamid
Copy link
Collaborator

@sajibAdhi @mitul3737 Please approve this PR

Copy link
Collaborator

@sajibAdhi sajibAdhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mitul3737 mitul3737 merged commit d3cf64a into cncf:dev-bn Feb 14, 2024
5 checks passed
@asem-hamid
Copy link
Collaborator

@Debaditya-Som you can find us here https://kubernetes.slack.com/messages/kubernetes-docs-bn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/bn for Bengali
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grammatical Errors in Bengali Version of Virtualization on CNCF Glossary
5 participants