Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update role-based-access-control.md #2437

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Conversation

juliafmorgado
Copy link
Contributor

Describe your changes

Updated the definition of Role-Based Access Control (RBAC) to be more precise and easier to understand.

Related issue number or link (ex: resolves #issue-number)

#2436

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 17ce366
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6540d282ac5f5c00082d8d81
😎 Deploy Preview https://deploy-preview-2437--cncfglossary.netlify.app/role-based-access-control
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/en for English label Sep 29, 2023
@jihoon-seo
Copy link
Collaborator

@juliafmorgado Thank you for your work, but please keep semantic line breaks. It will make review & localization processes easier.

Added a line break after each sentence.

Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Improved version of the definition with a better flow and clarity.

Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@iamNoah1 iamNoah1 linked an issue Oct 25, 2023 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically no changes, so ok from my side.

@github-actions
Copy link

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @juliafmorgado

/lgtm

content/en/role-based-access-control.md Outdated Show resolved Hide resolved
@github-actions
Copy link

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

1 similar comment
@github-actions
Copy link

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

Co-authored-by: Nate W <natew@cncf.io>
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@iamNoah1 iamNoah1 merged commit f068808 into cncf:main Oct 31, 2023
5 checks passed
@juliafmorgado juliafmorgado deleted the patch-2 branch October 31, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Update term] Role-Based Access Control for En
4 participants