-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update role-based-access-control.md #2437
Conversation
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@juliafmorgado Thank you for your work, but please keep semantic line breaks. It will make review & localization processes easier. |
Added a line break after each sentence. Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Improved version of the definition with a better flow and clarity. Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically no changes, so ok from my side.
To see where this is in the review pipeline and follow the progress, please look at the definition review board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update @juliafmorgado
/lgtm
To see where this is in the review pipeline and follow the progress, please look at the definition review board. |
1 similar comment
To see where this is in the review pipeline and follow the progress, please look at the definition review board. |
Co-authored-by: Nate W <natew@cncf.io> Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Describe your changes
Updated the definition of Role-Based Access Control (RBAC) to be more precise and easier to understand.
Related issue number or link (ex:
resolves #issue-number
)#2436
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.