Localize Contributor Ladder for Japanese #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naonishijima
requested review from
inductor,
kaitoii11 and
yuichi-nakamura
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
naonishijima
force-pushed
the
dev-ja-2124
branch
from
0da8f73 to
0cf5ed9
Compare
naonishijima
force-pushed
the
dev-ja-2124
branch
2 times, most recently
from
9b461b2 to
5e16805
Compare
kaitoii11
requested changes
Oct 4, 2023
|
|
||
| 承認者候補は、高品質のPRを提出し、他の人がPRをマージ可能な状態にするのを支援してきた実績があるべきです。また、タイムゾーンが許せば[用語集ワーキンググループのミーティング](https://www.cncf.io/calendar/)に定期的に出席してください。 | ||
|
|
||
| 承認者になるには、まず既存のメンテナーに興味を示すことから始めましょう。 既存のメンテナーはあなたに、彼らの指導のもとでPRを投稿したり、レビューをしたり、その他の仕事をしたり上記の資格を証明するよう求めます。しばらく一緒に仕事をした後、メンテナーはあなたに承認者の資格を与えるかどうかを決定します。この決定は、あなたが示した熟練度と対応能力に基づいて行われます。 |
There was a problem hiding this comment.
既存のメンテナーに興味を示す
細かいですが、既存のメンテナーに対して興味を示すとも読み取れてしまいます。
本来は「承認者になりたい」という意思表示を既存のメンテナに対してするという意味かと思います。
There was a problem hiding this comment.
レビューありがとうございます。「興味があることを既存のメンテナーに伝えることから始めましょう」に変更しました。
There was a problem hiding this comment.
変更をpushできてないみたいなので、お手すきの際にpushお願いしますー
There was a problem hiding this comment.
ご指摘ありがとうございます。pushし忘れていました…
Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com>
naonishijima
force-pushed
the
dev-ja-2124
branch
from
5e16805 to
cad6e1c
Compare
kaitoii11
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Localize Contributor Ladder for Japanese
Ladderの単語をどう翻訳するか迷いましたがカタカナでラダーにしました。
ご意見があればよろしくお願いします。
Related issue number or link (ex:
resolves #issue-number)#2124
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".