Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Create vertical-scaling.md #2626

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

Aryan-Singla
Copy link
Contributor

@Aryan-Singla Aryan-Singla commented Nov 14, 2023

Signed off: Aryan-Singla [devendergupta4573@gmail.com]

Describe your changes

Localize Vertical Scaling in Hindi

Related issue number or link (ex: resolves #issue-number)

resolves #2624

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit c462033
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6564d2ad92d1d20008ff64a4
😎 Deploy Preview https://deploy-preview-2626--cncfglossary.netlify.app/hi/vertical-scaling
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/hi for Hindi label Nov 14, 2023
@jihoon-seo jihoon-seo linked an issue Nov 16, 2023 that may be closed by this pull request
@seokho-son
Copy link
Collaborator

@ARYANis0001 I have a common comment on your PRs.
PTAL: #2605 (comment)

@justankiit
Copy link
Contributor

+1 @seokho-son

@Aryan-Singla
Copy link
Contributor Author

+1 @seokho-son

Hey @seokho-son
Hey @kumarankit999
I want to express my sincere apologies for any inconvenience caused to the team members of CNCF/Glossary due to my raised PRs. I fully understand my mistake and acknowledge that I need to be more careful in the future. Going forward, I will ensure to thoroughly read the contributing guidelines and submit PRs in my native language, which I am fluent in and proficient in.

Updated 

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
Add some hindi words

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
Copy link
Contributor Author

@Aryan-Singla Aryan-Singla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update (add some words)

@Aryan-Singla
Copy link
Contributor Author

Aryan-Singla commented Nov 21, 2023

Hey @aj11anuj @kumarankit999 please review it

Copy link
Contributor

@ankur0904 ankur0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at this suggestion.

Signed off: Aryan-Singla [devendergupta4573@gmail.com]

Signed-off-by: ARYAN <devendergupta4573@gmail.com>
@seokho-son seokho-son changed the title Create vertical-scaling.md [hi] Create vertical-scaling.md Nov 28, 2023
@Aryan-Singla
Copy link
Contributor Author

Please have a look at this suggestion.

Updated

Copy link
Contributor

@ankur0904 ankur0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aryan-Singla
Copy link
Contributor Author

Hey @aj11anuj @kumarankit999 please review it

Copy link
Collaborator

@Garima-Negi Garima-Negi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bishal7679 bishal7679 added the hold Wait, please do not proceed this yet label Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Wait, please do not proceed with this yet.

@Aryan-Singla
Copy link
Contributor Author

@bishal7679 why this hold label is added

Copy link
Collaborator

@abhay-raj19 abhay-raj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Thanks for contributing .

@Garima-Negi Garima-Negi merged commit 501d4bf into cncf:dev-hi Dec 12, 2023
5 checks passed
@Aryan-Singla Aryan-Singla deleted the patch-27 branch December 13, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hi] Localize Vertical Scaling
7 participants