-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tw] Localize Microservices Architecture
for Traditional Chinese
#2655
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a few of comments below, and thx for contributing 👍
感謝, 已更正 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@EmilyXinyi Please squash these commits into 1 commit before merging and thanks 🙏 |
done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miss link
Microservices Architecture
for Traditional Chinese (#2476)Microservices Architecture
for Traditional Chinese
13c4a39
to
8de18d4
Compare
Just pushed a commit that addressed the above review comments and squashed previous commits |
…ncf#2476) Signed-off-by: EmilyXinyi <xinyi_0302@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thank @EmilyXinyi
Describe your changes
original content from https://glossary.cncf.io/microservices-architecture/
Related issue number or link (ex:
resolves #issue-number
)resolves #2476
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.