Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Localize Microservices Architecture for Traditional Chinese #2655

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

EmilyXinyi
Copy link

Describe your changes

original content from https://glossary.cncf.io/microservices-architecture/

Related issue number or link (ex: resolves #issue-number)

resolves #2476

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 3cd2329
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/657110e7a6d683000861bec3
😎 Deploy Preview https://deploy-preview-2655--cncfglossary.netlify.app/zh-tw/microservices-architecture
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/tw for Traditional Chinese label Dec 1, 2023
Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a few of comments below, and thx for contributing 👍

content/zh-tw/microservices-architecture.md Outdated Show resolved Hide resolved
content/zh-tw/microservices-architecture.md Outdated Show resolved Hide resolved
content/zh-tw/microservices-architecture.md Outdated Show resolved Hide resolved
content/zh-tw/microservices-architecture.md Outdated Show resolved Hide resolved
content/zh-tw/microservices-architecture.md Outdated Show resolved Hide resolved
@EmilyXinyi
Copy link
Author

Leave a few of comments below, and thx for contributing 👍

感謝, 已更正

@jihoon-seo jihoon-seo linked an issue Dec 4, 2023 that may be closed by this pull request
Copy link
Collaborator

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pichuang
Copy link
Contributor

pichuang commented Dec 4, 2023

@EmilyXinyi Please squash these commits into 1 commit before merging and thanks 🙏

@EmilyXinyi
Copy link
Author

@EmilyXinyi Please squash these commits into 1 commit before merging and thanks 🙏

done, thanks!

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss link

content/zh-tw/microservices-architecture.md Outdated Show resolved Hide resolved
content/zh-tw/microservices-architecture.md Outdated Show resolved Hide resolved
@ydFu ydFu changed the title [tw] Localize Microservices Architecture for Traditional Chinese (#2476) [tw] Localize Microservices Architecture for Traditional Chinese Dec 5, 2023
@EmilyXinyi EmilyXinyi force-pushed the dev-tw branch 2 times, most recently from 13c4a39 to 8de18d4 Compare December 5, 2023 11:47
@EmilyXinyi
Copy link
Author

Just pushed a commit that addressed the above review comments and squashed previous commits

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thank @EmilyXinyi

@ydFu ydFu merged commit 2e23ba2 into cncf:dev-tw Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tw] Localize Microservices Architecture for Traditional Chinese
4 participants