Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] update Tightly Coupled Architecture #2658

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Garima-Negi
Copy link
Collaborator

Describe your changes

This PR fixes the filename and the page title for tightly coupled architecture.
This matches Title in 'loosely coupled architecture'

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • [x ] This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • [x ] I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit f9d47d4
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65de71559d4f530008c6b9d0
😎 Deploy Preview https://deploy-preview-2658--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/en for English label Dec 1, 2023
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Garima-Negi
Thanks! LGTM.

(please resolve the merge conflict)

@Garima-Negi
Copy link
Collaborator Author

Only those with write access to this repository can merge pull requests.

to resolve merge conflict, I'm getting this message in the PR UI :
Only those with [write access](https://docs.github.com/articles/what-are-the-different-access-permissions) to this repository can merge pull requests.

@seokho-son
Copy link
Collaborator

Hi @Garima-Negi :)
I don't recommend to use the "Resolve conflicts" in github UI, it frequently mix things.

Could you resolve the conflict by your local branch? If you feel difficult on that, you may open a new PR since the suggested change is simple.

@iamNoah1
Copy link
Collaborator

iamNoah1 commented Jan 4, 2024

hei @Garima-Negi, are you able to do it? Or do you need some support?

Signed-off-by: Garima Negi <garima.negy@gmail.com>
@nate-double-u nate-double-u force-pushed the fix-tightly-coupled-arch-typo branch from d1311a3 to f9d47d4 Compare February 27, 2024 23:33
@nate-double-u
Copy link
Member

I've rebased the commit on main

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Garima-Negi, and for your patience while we reviewed it.

@nate-double-u nate-double-u changed the title Fix filename and Title for tightly coupled architecture [EN] update Tightly Coupled Architecture Feb 27, 2024
@nate-double-u nate-double-u merged commit d3efe4f into cncf:main Feb 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
Development

Successfully merging this pull request may close these issues.

4 participants