Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords to wordlist.txt failing spellcheck #2684

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

srijanmishra
Copy link
Contributor

@srijanmishra srijanmishra commented Dec 6, 2023

Describe your changes

Issue #2679 mentions some keywords that were added previously when spellcheck workflow was not active. Now the checks are failing.

Adding the keywords should fix the Github spellcheck workflow.

Related issue number or link (ex: resolves #issue-number)

resolves #2679

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 24c8fd7
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65708fcdf54829000825985f
😎 Deploy Preview https://deploy-preview-2684--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Issue cncf#2679 mentions some keywords that were added previously when
spellcheck workflow was not active. Now the checks are failing.

Adding the keywords should fix the Github spellcheck workflow.

Signed-off-by: Srijan Mishra <srijan23mishra@gmail.com>
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @srijanmishra

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srijanmishra
LGTM.

Note: https://github.com/cncf/glossary/pull/2685/files also includes the same proposal. Let me coordinate it within the #2685

@seokho-son seokho-son merged commit dab1f20 into cncf:main Dec 7, 2023
5 checks passed
@seokho-son seokho-son mentioned this pull request Dec 7, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some words need to be added to wordlist.txt
3 participants