Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Localize Nodes for Japanese #2725

Merged
merged 8 commits into from
Dec 23, 2023
Merged

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Dec 16, 2023

Describe your changes

Localize Nodes for Japanese

Related issue number or link (ex: resolves #issue-number)

resolves #2719

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented Dec 16, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 849a55b
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6580f9da47471300083124a8
😎 Deploy Preview https://deploy-preview-2725--cncfglossary.netlify.app/ja/nodes
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/ja for Japanese label Dec 16, 2023
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya Okabe-Junya marked this pull request as ready for review December 17, 2023 08:26
content/ja/nodes.md Outdated Show resolved Hide resolved
content/ja/nodes.md Outdated Show resolved Hide resolved
Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
@Okabe-Junya
Copy link
Collaborator Author

@naonishijima

いつもレビューありがとうございます。確認、修正を行いましたので、再度ご確認いただけますと幸いです

Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitoii11 kaitoii11 merged commit 6e4b3a7 into cncf:dev-ja Dec 23, 2023
5 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-2719 branch December 23, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants