Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Localize Ingress for Japanese #2808

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Jan 16, 2024

Describe your changes

Localize Ingress for Japanese

Related issue number or link (ex: resolves #issue-number)

resolves #2747

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 9982f64
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65c39a29049959000802c0a9
😎 Deploy Preview https://deploy-preview-2808--cncfglossary.netlify.app/ja/ingress
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jihoon-seo jihoon-seo added the lang/ja for Japanese label Jan 16, 2024
Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tags: ["基礎"]
---

Ingressは、クラスター内で動作するコンテナあるいはコンテナ群へのインターネットトラフィックを外部から管理するためのルールセットです。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ルールセットを外部から管理する、と読み取れるような気がするので、ちょっと構成変えたほうが良いかもです。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

確かに修飾関係が少しおかしかったですね。

to manage internet traffic from outside into ...

だったので、「〜〜外部からのトラフィックを管理する」に修正しました

Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
@Okabe-Junya Okabe-Junya requested a review from kaitoii11 February 7, 2024 14:58
Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitoii11 kaitoii11 merged commit f05cce5 into cncf:dev-ja Feb 7, 2024
5 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-2747 branch February 7, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Localize Ingress for Japanese
4 participants