-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Localize Ingress for Japanese #2808
Conversation
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
content/ja/ingress.md
Outdated
tags: ["基礎"] | ||
--- | ||
|
||
Ingressは、クラスター内で動作するコンテナあるいはコンテナ群へのインターネットトラフィックを外部から管理するためのルールセットです。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ルールセットを外部から管理する、と読み取れるような気がするので、ちょっと構成変えたほうが良いかもです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。
確かに修飾関係が少しおかしかったですね。
to manage internet traffic from outside into ...
だったので、「〜〜外部からのトラフィックを管理する」に修正しました
Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
Localize Ingress for Japanese
Related issue number or link (ex:
resolves #issue-number
)resolves #2747
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.