Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial localization contributors list #2809

Conversation

naonishijima
Copy link
Collaborator

Describe your changes

Add initial localization contributors list in _index.md

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com>
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 4baba35
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65a6341eb16141000819694e
😎 Deploy Preview https://deploy-preview-2809--cncfglossary.netlify.app/ja
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seokho-son
Copy link
Collaborator

Hi folks~! :)
I think https://deploy-preview-2809--cncfglossary.netlify.app/ has some outdated contents. Please take a look for English latest version to update Japanese page upto date. :)

@yuichi-nakamura
Copy link
Collaborator

LGTM

@naonishijima
Copy link
Collaborator Author

@seokho-son We are looking over the contents again. Thank you!

@naonishijima naonishijima merged commit b61c485 into cncf:dev-ja Jan 22, 2024
6 of 7 checks passed
@Okabe-Junya
Copy link
Collaborator

Okabe-Junya commented Jan 26, 2024

@yuichi-nakamura

リリースされてから気づいたのですが、yuichiさんの名前が、Yuishi Nakamura (GitHub usernameとは異なる、おそらくtypo) になっていました。

Typoでなかったら大変申し訳ないのですが、もしそうであれば修正するPRを作成したいと思います

クラウドネイティブ用語集の日本語化は、[Kaito Ii](https://github.com/kaitoii11)[Kohei Ota](https://github.com/inductor)[Yuishi Nakamura](https://github.com/yuichi-nakamura)[MItabashi](https://github.com/bashi8128)[HANABE926](https://github.com/HANABE926)[Junya Okabe](https://github.com/Okabe-Junya)[Akira Aiura](https://github.com/A-aiura)[shizhenhu](https://github.com/shizhenhu)[Nao Nishijima](https://github.com/naonishijima)の貢献を通じて開始されました。

@naonishijima
Copy link
Collaborator Author

タイポです。PRを作成して頂ければ助かります。

@Okabe-Junya
Copy link
Collaborator

#2867 を作成しました

@naonishijima naonishijima deleted the update-initial-localization-contributors-list branch February 23, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants