Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to explicitly set HUGO_ENV in netlify.toml #2810

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Try to explicitly set HUGO_ENV in netlify.toml #2810

merged 1 commit into from
Jan 17, 2024

Conversation

cjyabraham
Copy link
Contributor

@cjyabraham cjyabraham commented Jan 16, 2024

To address this issue, we want to explicitly set HUGO_ENV so that it only is "production" on the production instance of the site. This is important so we don't run Google Analytics on preview or dev instances.

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 487ee0a
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65a6606381dc4d0008db6a8f
😎 Deploy Preview https://deploy-preview-2810--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjyabraham cjyabraham changed the title Try to explicitly set HUGO_ENV Try to explicitly set HUGO_ENV in netlify.toml Jan 16, 2024
@jihoon-seo jihoon-seo added the maintainers Use this label if PR requires maintainers to take action label Jan 17, 2024
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that GTM-related codes are not rendered in the source of preview.
LGTM!

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !! LGTM.

@seokho-son seokho-son merged commit b13089b into main Jan 17, 2024
8 checks passed
@cjyabraham cjyabraham deleted the build-env branch January 17, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants