Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info about not completed terms #2813

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

iamNoah1
Copy link
Collaborator

Describe your changes

When opening an issue, there was only a link to the glossary to check if suggested terms already exist. But we also have terms that are not finished, thus not show up in the glossary. Contributors who open an issue for a new term should also check there and create an issue to update the term instead of an issue to add the term.

Related issue number or link (ex: resolves #issue-number)

none

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>
@iamNoah1 iamNoah1 added the maintainers Use this label if PR requires maintainers to take action label Jan 17, 2024
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 365c1b8
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65aa3fc1ec75850008c7907e
😎 Deploy Preview https://deploy-preview-2813--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! a minor suggestion. :)

.github/ISSUE_TEMPLATE/new-term.yml Outdated Show resolved Hide resolved
Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seokho-son seokho-son merged commit caf996e into cncf:main Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants