[FR] Localize Ingress #2877
Merged
[FR] Localize Ingress #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-835
requested review from
huats,
fydrah,
Krast76,
sestegra and
guillaumebernard84
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
seb-835
commented
Jan 30, 2024
seb-835
commented
Jan 30, 2024
Closed
seb-835
commented
Jan 30, 2024
guillaumebernard84
requested changes
Jan 30, 2024
|
@seb-835 Il manque le signoff pour satisfaire le DCO |
Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
seb-835
force-pushed
the
dev-fr-ingress
branch
from
9e53c38 to
e13e743
Compare
|
Est-ce qu'on attends le résultat de la PR en VO avant de merge? Ou on merge comme ça et on modifiera plus tard? |
Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
On peut merge, et quand je recevrais l'acceptation de mes PR sur la VO, je ferrais immédiatement une PR de correction sur la FR. |
sestegra
requested changes
Feb 20, 2024
Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
|
@guillaumebernard84 Comme tu as demandé des modifications, tu dois aussi valider ce PR. |
Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
guillaumebernard84
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Localize Ingress
Related issue number or link (ex:
resolves #issue-number)resolves #2847
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".