Replace @pichuang with @tico88612 as zh-tw branch approver #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichuang
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Phil Huang <phil.huang@microsoft.com>
pichuang
force-pushed
the
replace-zh-tw-approver
branch
from
6ef6589 to
298f9af
Compare
|
Based on the past record of actual contribution to zh-tw, @tico88612 is recommended to be the reviewer of the project, in the hope that the project can move forward more continuously. |
nate-double-u
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Thanks for all your work @pichuang, and welcome to the team @tico88612!
|
Thanks @pichuang and welcome @tico88612 |
iamNoah1
approved these changes
Mar 9, 2024
|
Hi @nate-double-u @iamNoah1 
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Suggest that @pichuang 's own permissions be transferred to @tico88612 , who can contribute more to the glossary project
Related issue number or link (ex:
resolves #issue-number)Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".