Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Localize Canary Deployment into Japanese #2966

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Feb 28, 2024

Describe your changes

Localize Canary Deployment into Japanese

Related issue number or link (ex: resolves #issue-number)

resolves #2852

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 47601ec
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65ef30c9d7507c00085d5f8b
😎 Deploy Preview https://deploy-preview-2966--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya Okabe-Junya self-assigned this Feb 28, 2024
@Okabe-Junya Okabe-Junya linked an issue Feb 28, 2024 that may be closed by this pull request
@Okabe-Junya
Copy link
Collaborator Author

The target page on the deploy preview site:

Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


カナリアデプロイメントにより、組織は新しいソフトウェアが実際のシナリオでどのように振る舞うかを、新しいバージョンに大量のトラフィックを移行する前に確認することができます。
この戦略により、組織はダウンタイムを最小限に抑え、新しいデプロイメントに問題がある場合に迅速にロールバックすることができます。
また、全体的なユーザーエクスペリエンスに大きな影響を与えることなく、より深い本番アプリケーションのテストを可能にします。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文のin-depthからより深い...と約しているのかと思いますが、
徹底的ななどがより適切かと思います

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、47601ec で修正しました〜

Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
@Okabe-Junya Okabe-Junya requested a review from kaitoii11 March 11, 2024 16:27
@Okabe-Junya
Copy link
Collaborator Author

Okabe-Junya commented Mar 11, 2024

@kaitoii11

いつもありがとうございます〜!修正しましたので、再度ご確認お願いします

Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitoii11 kaitoii11 merged commit 8cc66c9 into cncf:dev-ja Mar 19, 2024
5 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-2852 branch March 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Localize Canary Deployment into Japanese
3 participants