Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] update redirect settings in Japanese Localization #2999

Closed

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Mar 22, 2024

Describe your changes

  • add redirect rules from /ja/microservices/ to /ja/microservices-architecture/ (same as English)
  • replace /ja/microservices-architecture/ to /ja/microservices/ in contents/ja dir

Background

When localizing, I often found it confusing to link to microservice pages because the destination page differs between Japanese and English.

English

Whenever you hear about [microservices](/microservices/) working together, you can infer that they interact via an API.

Japanese

[マイクロサービス](/ja/microservices-architecture/)が連携して動作しているのであれば、それはAPIを用いて相互に通信していると推測できます。

I thought it would be best to update the redirect rules to resolve this issue.

Related issue number or link (ex: resolves #issue-number)

No issue related to this PR

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@github-actions github-actions bot added the lang/ja for Japanese label Mar 22, 2024
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 3f62b58
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65fdcab3cafda00008892e4f
😎 Deploy Preview https://deploy-preview-2999--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya Okabe-Junya force-pushed the feat/redirect_microservices branch from da8883a to 3f62b58 Compare March 22, 2024 18:15
@Okabe-Junya Okabe-Junya self-assigned this Mar 22, 2024
@Okabe-Junya Okabe-Junya marked this pull request as ready for review March 22, 2024 18:27
@jihoon-seo jihoon-seo added the maintainers Use this label if PR requires maintainers to take action label Mar 25, 2024
@jihoon-seo
Copy link
Collaborator

@Okabe-Junya Thank you for the PR.
One thing is that:
You updated /ja/microservices-architecture/ links to /ja/microservices/, and I guess that you referred the upstream (English) files.
But IMO it is more appropriate to link to the final destination page (in this case, /lang/microservices-architecture/), and so we don't need to link to transient URLs (in this case, /lang/microservices/).

I tracked why the links in English pages have not been updated, and this is the related PRs:

  • #81: microservices.md was added.
  • #206, #211, #1199, : some links to /microservices/ were added.
  • #1549: renamed microservices.md to microservices-architecture.md, and added a redirection rule, but did not updated the links to /microservices/.

So my suggestion is

  1. First we update some links that points /microservices/ to point /microservices-architecture/ in all English files, and then
  2. Revert some changes of this PR to point /ja/microservices-architecture/, not /ja/microservices/.

I will open a PR that handles the first part of my suggestion.

@Okabe-Junya Okabe-Junya added the hold Wait, please do not proceed this yet label Mar 25, 2024
Copy link

Wait, please do not proceed with this yet.

@Okabe-Junya
Copy link
Collaborator Author

Thank you @jihoon-seo, I agree with your suggestion!!

So, I will close this pr after #3009 merges, is it right??

@jihoon-seo
Copy link
Collaborator

@Okabe-Junya
If #3009 gets merged, then please choose one option from:

  1. Revert some changes of this PR to point /ja/microservices-architecture/, not /ja/microservices/. (Update this PR, not closing)
  2. Or, close this PR and open a new one.

Either way is fine to me. 😊

@Okabe-Junya
Copy link
Collaborator Author

@jihoon-seo

Thank you for your comment!!

I think "Revert some changes of this PR to point /ja/microservices-architecture/, not /ja/microservices/" means closing this PR. (Because if revert, no changes in this PR)

@Okabe-Junya Okabe-Junya mentioned this pull request Mar 28, 2024
2 tasks
@Okabe-Junya
Copy link
Collaborator Author

friendly ping @jihoon-seo :)

Can I close this pr? thank you

@jihoon-seo
Copy link
Collaborator

@Okabe-Junya Sure, please go ahead!

@Okabe-Junya Okabe-Junya closed this Apr 6, 2024
@Okabe-Junya Okabe-Junya deleted the feat/redirect_microservices branch April 10, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet lang/ja for Japanese maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants