-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] update redirect settings in Japanese Localization #2999
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
da8883a
to
3f62b58
Compare
@Okabe-Junya Thank you for the PR. I tracked why the links in English pages have not been updated, and this is the related PRs:
So my suggestion is
I will open a PR that handles the first part of my suggestion. |
Wait, please do not proceed with this yet. |
Thank you @jihoon-seo, I agree with your suggestion!! So, I will close this pr after #3009 merges, is it right?? |
@Okabe-Junya
Either way is fine to me. 😊 |
Thank you for your comment!! I think "Revert some changes of this PR to point |
friendly ping @jihoon-seo :) Can I close this pr? thank you |
@Okabe-Junya Sure, please go ahead! |
Describe your changes
/ja/microservices/
to/ja/microservices-architecture/
(same as English)/ja/microservices-architecture/
to/ja/microservices/
incontents/ja
dirBackground
When localizing, I often found it confusing to link to microservice pages because the destination page differs between Japanese and English.
English
glossary/content/en/application-programming-interface.md
Line 24 in 83d8503
Japanese
glossary/content/ja/application-programming-interface.md
Line 24 in 83d8503
I thought it would be best to update the redirect rules to resolve this issue.
Related issue number or link (ex:
resolves #issue-number
)No issue related to this PR
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.