-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] rename tightly-coupled-architectures.md
to tightly-coupled-architecture.md
#3006
Conversation
…htly-coupled-architecture.md Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全ページを確認したわけじゃないですが、少なくともcontent/ja/loosely-coupled-architecture.md
は文中のリンクを修正する
必要があります。
こちらも合わせて修正お願いできますか。
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
ありがとうございます。ご指摘いただいた通りですね。以下の4ファイルからリンクされていたので、合わせて修正させて頂きました $ pwd
/path/to/glossary
$ grep "tightly-coupled-architectures" -rl ./content/ja
./content/ja/microservices-architecture.md
./content/ja/cloud-native-apps.md
./content/ja/loosely-coupled-architecture.md
./content/ja/devops.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…chitecture.md` (cncf#3006) Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> Signed-off-by: shinji <earlybird787@gmail.com>
Describe your changes
"密結合アーキテクチャ" のファイル名が日本語と英語で異なっていたため、修正しました
Related issue number or link (ex:
resolves #issue-number
)No issue related to this pr
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.