Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] rename tightly-coupled-architectures.md to tightly-coupled-architecture.md #3006

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Mar 23, 2024

Describe your changes

"密結合アーキテクチャ" のファイル名が日本語と英語で異なっていたため、修正しました

Related issue number or link (ex: resolves #issue-number)

No issue related to this pr

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

…htly-coupled-architecture.md

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 01f5efe
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6602bc9a234afc0008254c48
😎 Deploy Preview https://deploy-preview-3006--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya Okabe-Junya self-assigned this Mar 23, 2024
Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全ページを確認したわけじゃないですが、少なくともcontent/ja/loosely-coupled-architecture.mdは文中のリンクを修正する
必要があります。
こちらも合わせて修正お願いできますか。

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya
Copy link
Collaborator Author

ありがとうございます。ご指摘いただいた通りですね。以下の4ファイルからリンクされていたので、合わせて修正させて頂きました

$ pwd
/path/to/glossary
$ grep  "tightly-coupled-architectures"  -rl ./content/ja
./content/ja/microservices-architecture.md
./content/ja/cloud-native-apps.md
./content/ja/loosely-coupled-architecture.md
./content/ja/devops.md

@Okabe-Junya Okabe-Junya requested a review from kaitoii11 March 26, 2024 12:17
Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitoii11 kaitoii11 merged commit 8175832 into cncf:dev-ja Mar 26, 2024
5 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-file-name branch March 26, 2024 12:31
@Okabe-Junya Okabe-Junya mentioned this pull request Mar 28, 2024
2 tasks
shinj05 pushed a commit to shinj05/glossary that referenced this pull request Apr 7, 2024
…chitecture.md` (cncf#3006)

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Signed-off-by: shinji <earlybird787@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants