-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] fix SRE to Japanese #3039
[ja] fix SRE to Japanese #3039
Conversation
Signed-off-by: Kazunori Otani <kotani@splunk.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらもありがとうございます!
一点だけコメントさせて頂きました、取り込むかどうかはお任せします!
別途で、タイトルに日本語文字は含めないように修正いただきたいです。((日本語話者ではない)repo全体のメンテナが確認/管理しづらくなってしまうためです)
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> Signed-off-by: Kazunori Otani <katzchang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらもご対応ありがとうございます!LGTMです!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
Site Reliability EngineeringおよびSite Reliability Engineerの訳語を、「サイト信頼性エンジニアリング」および「サイト信頼性エンジニア」に変更しました。
日本語「サイト信頼性エンジニア」は、https://cloud.google.com/sre?hl=ja などでも使われいる表現で、そちらに倣うための変更です。
Related issue number or link (ex:
resolves #issue-number
)Related: #3035 (comment)
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.