Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sign Language Video Style Guide to index.md #3313

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Add Sign Language Video Style Guide to index.md #3313

merged 4 commits into from
Nov 4, 2024

Conversation

Deafveloper
Copy link
Contributor

added the sign language video style guide

Describe your changes

Added an anchor link under Audience and added the video style guide after getting started with a google doc

Related issue number or link (ex: resolves #issue-number)

related to issue #3040

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@github-actions github-actions bot added the lang/en for English label Sep 10, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 10, 2024 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 6d17289
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6723b5d34e9f9a00087f871a
😎 Deploy Preview https://deploy-preview-3313--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Deafveloper Deafveloper marked this pull request as draft September 12, 2024 15:43
@Deafveloper Deafveloper changed the base branch from main to dev-sign September 12, 2024 15:47
@Deafveloper Deafveloper changed the title Updated index.md Add Sign Language Video Style Guide to index.md Sep 12, 2024
@seokho-son
Copy link
Collaborator

Hi @Deafveloper, this PR includes many commits from other contributors. :)
I believe this happened because you've based your commit on a different branch instead of the dev-sign branch.

Let me check if simply changing the target branch to main branch will fix the issue. (I don't mind if we use the main branch directly.)
If you're not too familiar with Git/GitHub branch concept, the above comment might be a bit confusing. But don't worry, I'll help you through it!

@seokho-son seokho-son changed the base branch from dev-sign to main September 13, 2024 03:50
@seokho-son
Copy link
Collaborator

Yes, the base branch of your local/feature is main. You can see this PR includes your commits only.

So, we either need to change the target branch of this PR (which I’ve already done) or change your base branch to dev-sign (though this isn't simple).

Why don’t we just use the main branch for this PR? We can decide when to merge it once the reviews are completed.

@Deafveloper
Copy link
Contributor Author

@seokho-son Yes that is exactly what happened. I changed the branch after my commit. I’m still getting the hang of the Git/GitHub branch concepts, so I appreciate your patience.

I’m happy to learn and follow any steps you suggest.

Thanks again for your help!

@Deafveloper
Copy link
Contributor Author

Thank you @tech-andgar! I added your suggestions. @jtjackson lmk wyt?

@jtjackson
Copy link

LGTM 🙂

@Deafveloper Deafveloper marked this pull request as ready for review October 29, 2024 11:41
jtjackson
jtjackson approved these changes Oct 31, 2024
View reviewed changes
Copy link

@jtjackson jtjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get this out.

Deafveloper and others added 4 commits October 31, 2024 12:44
@Deafveloper
Updated index.md
b79ec58 
added the sign language video style guide

Signed-off-by: Deafveloper <destinymoconnor@gmail.com>
@Deafveloper
Fix the Sign Language Video Style Guide in _index.md
eaade8d 
Deleted extra space and made the text bold with the bullet points.

Signed-off-by: Destiny O'Connor <108372508+Deafveloper@users.noreply.github.com>
Signed-off-by: Deafveloper <destinymoconnor@gmail.com>
@Deafveloper
Update _index.md
b6a3b0d 
changed the heading into regular text under the SL video guide heading

Signed-off-by: Destiny O'Connor <108372508+Deafveloper@users.noreply.github.com>
Signed-off-by: Deafveloper <destinymoconnor@gmail.com>
@Deafveloper
Update Index.md
6d17289 
Added @tech-andgar Suggestions

Signed-off-by: Deafveloper <destinymoconnor@gmail.com>
@seokho-son
Copy link
Collaborator

LGTM!! :)

@seokho-son seokho-son merged commit 14caba6 into cncf:main Nov 4, 2024
7 checks passed
This was referenced Nov 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tech-andgar tech-andgar tech-andgar left review comments

@jtjackson jtjackson jtjackson approved these changes

@seokho-son seokho-son seokho-son approved these changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@iamNoah1 iamNoah1 Awaiting requested review from iamNoah1 iamNoah1 is a code owner

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo jihoon-seo is a code owner

@nate-double-u nate-double-u Awaiting requested review from nate-double-u nate-double-u is a code owner

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
lang/en for English
Projects
CNCF glossary definition review board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Deafveloper @seokho-son @jtjackson @tech-andgar