Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize cloud computing for Korean #334

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Localize cloud computing for Korean #334

merged 1 commit into from
Jan 25, 2022

Conversation

seokho-son
Copy link
Collaborator

This PR provides
Localized content/en/cloud_computing.md document.
(also to check push permission)

@seokho-son seokho-son added the lang/ko for Korean label Jan 18, 2022
@seokho-son
Copy link
Collaborator Author

It seems

https://github.com/cncf/glossary/blob/main/CODEOWNERS works well. :)
image

@jihoon-seo
Copy link
Collaborator

jihoon-seo commented Jan 18, 2022 •
edited
Loading

It seems that I have the permission to merge. 😊

image

@seokho-son
Copy link
Collaborator Author

FYI: current collaborators and permission.

image

@seokho-son
Copy link
Collaborator Author

seokho-son commented Jan 18, 2022 •
edited
Loading

FYI: some settings not working. (settings App issue)

  • Restrict who can push to matching branches collaborator who does not accept invitation is not listed
  • in case of jihoon-seo, I added him by myself in Github UI (not using settings.yaml app)
  • Eviekim who is not collaborator yet is not listed

image

@seokho-son
Copy link
Collaborator Author

https://github.com/cncf/glossary/blob/main/.github/settings.yml
image

@seokho-son seokho-son changed the title Localize cloud computing for Korean Localize cloud computing for Korean (push permission test) Jan 18, 2022
@Eviekim Eviekim self-requested a review January 18, 2022 11:54
@Eviekim
Copy link

Eviekim commented Jan 18, 2022

Screenshot 2022-01-18 at 11 55 03

I do have the permission to review and approve PR as well!

@seokho-son seokho-son mentioned this pull request Jan 20, 2022
Merged
@seokho-son
Copy link
Collaborator Author

@Eviekim @jihoon-seo
Please merge this PR. You can merge a PR in dev-ko branch.

@jihoon-seo jihoon-seo merged commit e3365ad into cncf:dev-ko Jan 25, 2022
@seokho-son seokho-son changed the title Localize cloud computing for Korean (push permission test) Localize cloud computing for Korean Feb 3, 2022
@seokho-son seokho-son mentioned this pull request Feb 3, 2022
Closed
yunkon-kim pushed a commit to yunkon-kim/glossary that referenced this pull request Mar 10, 2022
@seokho-son @yunkon-kim
Localize cloud computing for Korean (cncf#334)
198afef
yunkon-kim pushed a commit to yunkon-kim/glossary that referenced this pull request Mar 10, 2022
@seokho-son @yunkon-kim
Localize cloud computing for Korean (cncf#334)
97253de
yunkon-kim pushed a commit to yunkon-kim/glossary that referenced this pull request Mar 10, 2022
@seokho-son @yunkon-kim
Localize cloud computing for Korean (cncf#334)
661af22
yunkon-kim pushed a commit to yunkon-kim/glossary that referenced this pull request Apr 21, 2022
@seokho-son @yunkon-kim
Localize cloud computing for Korean (cncf#334)
ce91549
yunkon-kim pushed a commit to yunkon-kim/glossary that referenced this pull request Apr 21, 2022
@seokho-son @yunkon-kim
Localize cloud computing for Korean (cncf#334)
d6a4823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo jihoon-seo approved these changes

@Eviekim Eviekim Eviekim approved these changes

Assignees
No one assigned
Labels
lang/ko for Korean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seokho-son @jihoon-seo @Eviekim