-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings and initial contents for Bengali localization #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitul3737
requested review from
caniszczyk,
CathPag,
JasonMorgan and
seokho-son
as code owners
January 31, 2022 18:55
seokho-son
requested changes
Feb 2, 2022
The website looks fine @seokho-son . Can you review it? |
seokho-son
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Thanks!
CathPag
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 tasks
jihoon-seo
pushed a commit
to jihoon-seo/cncf-glossary
that referenced
this pull request
May 12, 2022
* Creating contribute folder and _index.md * Create style-guide folder and _index.md * Creating _index.md for dev-bn branch * Create cloud_native_tech.md in bengali * Creating bn.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to initiate Bengali localization based on
Base and target branch of this PR is
dev-bn
which is development branch for Bengali localization.This PR includes
[languages.bn]
section inconfig.toml
Since Bengali localization team owns
content/bn/*
only,this PR will require approvals from upstream owners (maintainers).
Track issue: #410