Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass for the style guide #38

Merged
merged 3 commits into from
Feb 21, 2021
Merged

First pass for the style guide #38

merged 3 commits into from
Feb 21, 2021

Conversation

IdealUsrname
Copy link
Contributor

Closes #6

I added some extra categories. I would love feedback on formatting.

Solving for #6 

I added some extra categories. Would love feedback on formatting.
Fixed two typos and a spacing issue
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Only one question, how do we envision using: Tool, Opposite of "Other Definition", Application, Objective, Application in the glossary?

Fixed two typos and a spacing issue and committed directly to your branch since it was just a detail. Is that ok or should I create a PR moving forward? Wanna do whatever is best practice.

@IdealUsrname
Copy link
Contributor Author

Looks great to me. Only one question, how do we envision using: Tool, Opposite of "Other Definition", Application, Objective, Application in the glossary?

I put them there for a discussion. It might be best to leave everything as a concept and decide later?

Fixed two typos and a spacing issue and committed directly to your branch since it was just a detail. Is that ok or should I create a PR moving forward? Wanna do whatever is best practice.

Thanks, @CathPag!

Small typos are easy to fix like that. Appreciate it.

A discussion should be created around how categories will be used.
@IdealUsrname IdealUsrname merged commit 773dd3a into main Feb 21, 2021
@IdealUsrname IdealUsrname deleted the mfoster/style-guide branch February 21, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Style Guide
2 participants