Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Localize continuous integration.md #420

Merged
merged 4 commits into from
Feb 15, 2022
Merged

[hi] Localize continuous integration.md #420

merged 4 commits into from
Feb 15, 2022

Conversation

Aayush987
Copy link
Contributor

Hi,
This Pr is Hindi localization of content/hi/continuous_integration.md page.

ref : #270
/lang hi

@anubha-v-ardhan @Garima-Negi and everyone plz review.

@netlify
Copy link

netlify bot commented Feb 11, 2022 •
edited
Loading

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: dc8110e

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/620bc77865f96300071bc35b

😎 Browse the preview: https://deploy-preview-420--cncfglossary.netlify.app

@CathPag CathPag added the lang/hi for Hindi label Feb 11, 2022
anubha-v-ardhan
anubha-v-ardhan approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @Aayush987

@Garima-Negi Garima-Negi mentioned this pull request Feb 11, 2022
Closed
23 tasks
sayantani11
sayantani11 reviewed Feb 15, 2022
View reviewed changes
content/hi/continuous_integraion.md Outdated

## यह क्या है

निरंतर एकीकरण (Continuous_Integration) , जिसे अक्सर CI कहा जाता है, कोड परिवर्तन को जल्दी से जल्दी एकीकृत करने का एक अभ्यास है। CI, [CD](/Continuous_Delivery/) पढ़ने के लिए आवश्यक है। ऐतिहासिक रूप से, CI की प्रक्रिया तब शरू होती है जब कोड परिवर्तन को सोर्स नियंत्रण सिस्टम (Git, Mercurial, या Subversal) में कमिट किया जाता है और वह परीक्षित उत्पाद, CD सिस्टम में जाने के लिए तैयार होता है।
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we shouldn't change the topic name to निरंतर एकीकरण as continuous Integration is a technical term

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we put continuous integration in parenthesis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the title?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the topic:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@anubha-v-ardhan anubha-v-ardhan self-requested a review February 15, 2022 15:00
anubha-v-ardhan
anubha-v-ardhan reviewed Feb 15, 2022
View reviewed changes
content/hi/continuous_integraion.md Outdated
@@ -0,0 +1,17 @@
---
title: निरंतर एकीकरण (Continuous_Integration)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: निरंतर एकीकरण (Continuous_Integration)
title: निरंतर एकीकरण (Continuous Integration)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ seems unnecessary here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sorry.

anubha-v-ardhan
anubha-v-ardhan reviewed Feb 15, 2022
View reviewed changes
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name should be continuous_integration.md and not continuous_integraion.md. I think we missed "t" in "integration" by mistake

@Aayush987
Copy link
Contributor Author

The file name should be continuous_integration.md and not continuous_integraion.md. I think we missed "t" in "integration" by mistake

OK, sorry my bad.

@anubha-v-ardhan
Copy link
Contributor

Thank you @Aayush987 :)

@anubha-v-ardhan anubha-v-ardhan merged commit dcc958e into cncf:dev-hi Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan approved these changes

@sayantani11 sayantani11 sayantani11 approved these changes

@Garima-Negi Garima-Negi Awaiting requested review from Garima-Negi Garima-Negi is a code owner

@jayesh-srivastava jayesh-srivastava Awaiting requested review from jayesh-srivastava jayesh-srivastava is a code owner

Assignees
No one assigned
Labels
lang/hi for Hindi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aayush987 @anubha-v-ardhan @sayantani11 @CathPag