Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings and initial contents for Chinese localization #464

Merged
merged 2 commits into from
Feb 27, 2022

Conversation

hanyuancheung
Copy link
Collaborator

@hanyuancheung hanyuancheung commented Feb 21, 2022

This PR is to initiate Chinese localization based on

Base and target branch of this PR is dev-zh which is the development branch for Chinese localization.

This PR includes

  • [languages.zh] section in config.toml
  • content/zh/ directory
  • i18n/zh.toml
  • Some translated documents
    • Main page
      • content/zh/_index.md
    • Terms
      • "Cloud Native Technology": content/zh/cloud_native_tech.md
    • Others
      • contribute: content/zh/contribute/_index.md (partially localized)
      • style-guide: content/zh/style-guide/_index.md (partially localized)

Since the Chinese localization team owns content/zh/* only,
this PR will require approvals from upstream owners (maintainers).

@seokho-son
Copy link
Collaborator

seokho-son commented Feb 22, 2022

@hanyuancheung ! Thank you for the contribution ! :)

We are going to check following tasks in this PR. (target branch is dev-zh)

In the meantime,

  1. Since I cannot review Chinese contents, could you invite volunteers who can review Chinese contents in this PR ? (I expect two reviewers' LGTM)
  2. Cloud you test Hugo Build locally for this PR to verify the configuration works ? (This page does not have Netlify preview yet)

@netlify
Copy link

netlify bot commented Feb 22, 2022

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: 0670138

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6214579d9178c7000739a011

😎 Browse the preview: https://deploy-preview-464--cncfglossary.netlify.app

@hanyuancheung
Copy link
Collaborator Author

截屏2022-02-22 上午11 19 59

I've tested Hugo Build locally and successfully.
Cause I don't have the permission to invite reviewers, @seokho-son could you please help to add the approver permission? I'll invite and inform them to review this PR. Thx.

@seokho-son
Copy link
Collaborator

@hanyuancheung

I've tested Hugo Build locally and successfully.

Thanks !! :) We enabled Netlify preview as well.
https://deploy-preview-464--cncfglossary.netlify.app/zh/

Cause I don't have the permission to invite reviewers, @seokho-son could you please help to add the approver permission? I'll invite and inform them to review this PR. Thx.

We have additional procedure to give a permission :)
(need a consensus from maintainers first. I am going to arrange it)

The reviews I requested is about having comments, discussion, and consensus among Chinese volunteers using Comments in this PR. The volunteers can leave LGTM comment. don't need to approve this PR.
With LGTM comments, I will assume the Chinese contents in this PR has some agreement :)

(We hope to see some activities of volunteers who will apply for approvers)

Copy link
Collaborator

@Jacob953 Jacob953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@Rocksnake Rocksnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Submarinee
Copy link
Collaborator

LGTM.

@hanyuancheung
Copy link
Collaborator Author

@seokho-son I found that the approvers are added successfully. Could this PR also be merged?

Copy link
Collaborator

@Jacob953 Jacob953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@Rocksnake Rocksnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

This PR includes contents outside /zh/* so requires maintainer's approval and merge.

@seokho-son seokho-son merged commit 84fe596 into cncf:dev-zh Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/zh for Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants