-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings and initial contents for Chinese localization #464
Conversation
@hanyuancheung ! Thank you for the contribution ! :) We are going to check following tasks in this PR. (target branch is dev-zh)
In the meantime,
|
✔️ Deploy Preview for cncfglossary ready! 🔨 Explore the source changes: 0670138 🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6214579d9178c7000739a011 😎 Browse the preview: https://deploy-preview-464--cncfglossary.netlify.app |
I've tested Hugo Build locally and successfully. |
Thanks !! :) We enabled Netlify preview as well.
We have additional procedure to give a permission :) The reviews I requested is about having comments, discussion, and consensus among Chinese volunteers using Comments in this PR. The volunteers can leave (We hope to see some activities of volunteers who will apply for approvers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
LGTM. |
@seokho-son I found that the approvers are added successfully. Could this PR also be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
This PR includes contents outside /zh/* so requires maintainer's approval and merge.
This PR is to initiate Chinese localization based on
Base and target branch of this PR is dev-zh which is the development branch for Chinese localization.
This PR includes
Since the Chinese localization team owns content/zh/* only,
this PR will require approvals from upstream owners (maintainers).