Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution.md #477

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Update contribution.md #477

merged 1 commit into from
Feb 25, 2022

Conversation

iamNoah1
Copy link
Collaborator

update list of people to notify in case someone wants to work on a new English glossary term, as Jihoon and me are now also English approvers

update list of people to notify in case someone wants to work on a new English glossary term, as Jihoon and me are now also English approvers
@netlify
Copy link

netlify bot commented Feb 24, 2022

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: ecd3237

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6217bdd8fa6373000858d335

😎 Browse the preview: https://deploy-preview-477--cncfglossary.netlify.app

@iamNoah1 iamNoah1 added the maintainers Use this label if PR requires maintainers to take action label Feb 24, 2022
Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@seokho-son seokho-son merged commit 74dc0fb into main Feb 25, 2022
@jihoon-seo jihoon-seo deleted the iamNoah1-patch-1 branch February 25, 2022 02:36
@jihoon-seo
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants