Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Add 10 .md localizations #496

Merged
merged 19 commits into from
Mar 30, 2022
Merged

[zh] Add 10 .md localizations #496

merged 19 commits into from
Mar 30, 2022

Conversation

Jacob953
Copy link
Collaborator

@Jacob953 Jacob953 commented Feb 28, 2022 •
edited
Loading

Done

  • Add cluster.md localization to zh.
  • Add cloud_native_apps.md localization to zh.
  • Add cloud_native_security.md localization to zh.
  • Add contianer_image.md localization to zh.
  • Add containization.md localization to zh.
  • Add contianer_as_a_server.md localization to zh.
  • Add kubernetes.md localization to zh.
  • Fix typos of cloud_native_tech.md
  • Add countinuous_integration.md localization to zh.
  • Add countinuous_delivery.md localization to zh.

@netlify
Copy link

netlify bot commented Feb 28, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 4d78326
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6242c0b2347473000872d913
😎 Deploy Preview https://deploy-preview-496--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hanyuancheung
Copy link
Collaborator

Good work! This PR should be reviewed after #489. Before that, don't forget to rebase it.

@Jacob953
Copy link
Collaborator Author

Jacob953 commented Mar 1, 2022

Good work! This PR should be reviewed after #489. Before that, don't forget to rebase it.

I'll handle this. Thx!

@jihoon-seo jihoon-seo added the lang/zh for Chinese label Mar 2, 2022
Submarinee
Submarinee reviewed Mar 2, 2022
View reviewed changes
content/zh/cluster.md Outdated Show resolved Hide resolved
@Submarinee
Copy link
Collaborator

LGTM.

@Jacob953 Jacob953 changed the title Add content/zh/cluster.md Add 3 .md localizations to zh Mar 23, 2022
@Jacob953 Jacob953 changed the title Add 3 .md localizations to zh Add 4 .md localizations to zh Mar 24, 2022
@Jacob953 Jacob953 changed the title Add 4 .md localizations to zh [zh] Add 8 .md localizations Mar 26, 2022
@Jacob953 Jacob953 changed the title [zh] Add 8 .md localizations [zh] Add 10 .md localizations Mar 29, 2022
@Jacob953
Copy link
Collaborator Author

I just figured out some conflict here by my mistakes.

container_image.md #590 and continuous_delivery.md #591 existed.

hanyuancheung
hanyuancheung approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! LGTM. Thanks for your contribution.

The other new items should be split into different PRs, this one is forgiven.

Rocksnake
Rocksnake approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@Rocksnake Rocksnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@hanyuancheung hanyuancheung merged commit 507138b into cncf:dev-zh Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Submarinee Submarinee Submarinee left review comments

@Rocksnake Rocksnake Rocksnake approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@edsoncelio edsoncelio Awaiting requested review from edsoncelio

@brunoguidone brunoguidone Awaiting requested review from brunoguidone

@jessicalins jessicalins Awaiting requested review from jessicalins

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@CathPag CathPag Awaiting requested review from CathPag CathPag is a code owner

@JasonMorgan JasonMorgan Awaiting requested review from JasonMorgan JasonMorgan is a code owner

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

Assignees
No one assigned
Labels
lang/zh for Chinese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jacob953 @hanyuancheung @Submarinee @Rocksnake @jihoon-seo